chrome/browser/chromeos/login/existing_user_controller.cc - Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/existing_user_controller.cc

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased on ToT+Part1 and addressed comments. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/cros_settings_provider.cc ('k') | chrome/browser/chromeos/login/login_performer.cc » ('j') | chrome/browser/chromeos/login/signed_settings.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/existing_user_controller.cc

diff --git a/chrome/browser/chromeos/login/existing_user_controller.cc b/chrome/browser/chromeos/login/existing_user_controller.cc

index e4b5c0de0d8cf8779bfda5f19a9af09d294637fe..19f0ddb5a80b7184b7152c63dca0791da73d96fd 100644

--- a/chrome/browser/chromeos/login/existing_user_controller.cc

+++ b/chrome/browser/chromeos/login/existing_user_controller.cc

@@ -102,14 +102,12 @@ void ExistingUserController::Init(const UserList& users) {

&show_users_on_signin);

if (show_users_on_signin) {

bool allow_new_user = false;

- const base::ListValue *user_list;

cros_settings_->GetBoolean(kAccountsPrefAllowNewUser, &allow_new_user);

- cros_settings_->GetList(kAccountsPrefUsers, &user_list);

for (UserList::const_iterator it = users.begin(); it != users.end(); ++it) {

- base::StringValue email((*it)->email());

// TODO(xiyuan): Clean user profile whose email is not in whitelist.

if (allow_new_user ||

- user_list->Find(email) != user_list->end()) {

+ cros_settings_->FindEmailInList(kAccountsPrefUsers,

+ (*it)->email())) {

filtered_users.push_back(*it);

}