chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc - Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments and fixed an issue with user whitelist checks. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/user_cros_settings_provider.cc ('K') | « chrome/browser/chromeos/user_cros_settings_provider.cc ('k') | chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc

index a84771ca507a06442974c2e65d0470e972ff104b..c7b8e316ce181123448ca88d5811b80afbd42b4d 100644

--- a/chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc

@@ -101,14 +101,11 @@ void AccountsOptionsHandler::UnwhitelistUser(const base::ListValue* args) {

void AccountsOptionsHandler::WhitelistExistingUsers(

const base::ListValue* args) {

base::ListValue whitelist_users;

- const base::ListValue *user_list;

- CrosSettings::Get()->GetList(kAccountsPrefUsers, &user_list);

UserVector users = UserManager::Get()->GetUsers();

for (UserVector::const_iterator it = users.begin();

it < users.end(); ++it) {

const std::string& email = it->email();

- base::StringValue email_value(email);

- if (user_list->Find(email_value) == user_list->end()) {

+ if (CrosSettings::Get()->FindEmailInList(kAccountsPrefUsers, email)) {

base::DictionaryValue* user_dict = new DictionaryValue;

user_dict->SetString("name", it->GetDisplayName());

user_dict->SetString("email", email);