chrome/browser/chromeos/cros_settings_provider.h - Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/cros_settings_provider.h

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased on ToT and made clang happy. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/cros_settings.cc ('K') | « chrome/browser/chromeos/cros_settings.cc ('k') | chrome/browser/chromeos/cros_settings_provider.cc » ('j') | chrome/browser/chromeos/login/signed_settings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/cros_settings_provider.h

diff --git a/chrome/browser/chromeos/cros_settings_provider.h b/chrome/browser/chromeos/cros_settings_provider.h

index e5012c346ca567b9eb761c77961a8e9446058a2a..53157aa1544a7038efbf48e90019204ff27a71af 100644

--- a/chrome/browser/chromeos/cros_settings_provider.h

+++ b/chrome/browser/chromeos/cros_settings_provider.h

@@ -21,7 +21,7 @@ class CrosSettingsProvider {

// Sets |in_value| to given |path| in cros settings.

// Note that this takes ownership of |in_value|.

Mattias Nissler (ping if slow) 2011/10/07 11:02:57 comment is wrong.

pastarmovj 2011/10/13 11:25:06 Done.

- void Set(const std::string& path, base::Value* in_value);

+ void Set(const std::string& path, const base::Value& in_value);

// Gets settings value of given |path| to |out_value|.

virtual const base::Value* Get(const std::string& path) const = 0;

@@ -36,7 +36,8 @@ class CrosSettingsProvider {

private:

// Does the real job for Set().

- virtual void DoSet(const std::string& path, base::Value* in_value) = 0;

+ virtual void DoSet(const std::string& path,

+ const base::Value& in_value) = 0;

};

} // namespace chromeos