chrome/browser/chromeos/login/wizard_controller.cc - Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/wizard_controller.cc

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments and rebased on a the current PART1 version. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/login/signed_settings_unittest.cc ('K') | « chrome/browser/chromeos/login/signed_settings_unittest.cc ('k') | chrome/browser/chromeos/proxy_config_service_impl.h » ('j') | chrome/browser/chromeos/user_cros_settings_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/wizard_controller.cc

diff --git a/chrome/browser/chromeos/login/wizard_controller.cc b/chrome/browser/chromeos/login/wizard_controller.cc

index d13fa2c0b294c8e31e7b29f859e829cf6abb5524..b800222ee0552a39e7a8341f99a4570f647b0feb 100644

--- a/chrome/browser/chromeos/login/wizard_controller.cc

+++ b/chrome/browser/chromeos/login/wizard_controller.cc

@@ -392,9 +392,10 @@ void WizardController::OnEulaAccepted() {

// But we can at least create the consent file and Chrome would port that

// if the device is owned by a local user. In case of enterprise enrolled

// device the setting will be respected only until the policy is not set.

+ base::FundamentalValue value(usage_statistics_reporting_);

SignedSettingsTempStorage::Store(

kStatsReportingPref,

- (usage_statistics_reporting_ ? "true" : "false"),

+ value,

g_browser_process->local_state());

bool enabled =

OptionsUtil::ResolveMetricsReportingEnabled(usage_statistics_reporting_);