Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4750)

Unified Diff: chrome/browser/chromeos/login/signed_settings_helper_unittest.cc

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments and rebased on a the current PART1 version. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/signed_settings_helper_unittest.cc
diff --git a/chrome/browser/chromeos/login/signed_settings_helper_unittest.cc b/chrome/browser/chromeos/login/signed_settings_helper_unittest.cc
index 8de228ce0b5632608ecd768a03d989c4b9059e00..81a553e56209fb1bf7273a72d905266f01d50cb2 100644
--- a/chrome/browser/chromeos/login/signed_settings_helper_unittest.cc
+++ b/chrome/browser/chromeos/login/signed_settings_helper_unittest.cc
@@ -39,11 +39,11 @@ class MockSignedSettingsHelperCallback : public SignedSettingsHelper::Callback {
MOCK_METHOD3(OnStorePropertyCompleted, void(
SignedSettings::ReturnCode code,
const std::string& name,
- const std::string& value));
+ const base::Value& value));
MOCK_METHOD3(OnRetrievePropertyCompleted, void(
SignedSettings::ReturnCode code,
const std::string& name,
- const std::string& value));
+ const base::Value& value));
};
class SignedSettingsHelperTest : public testing::Test,
@@ -51,7 +51,7 @@ class SignedSettingsHelperTest : public testing::Test,
public:
SignedSettingsHelperTest()
: fake_email_("fakey@example.com"),
- fake_prop_(kAccountsPrefAllowGuest),
+ fake_prop_(kReleaseChannel),
fake_value_("false"),
message_loop_(MessageLoop::TYPE_UI),
ui_thread_(BrowserThread::UI, &message_loop_),
@@ -96,7 +96,7 @@ class SignedSettingsHelperTest : public testing::Test,
const std::string fake_email_;
const std::string fake_prop_;
- const std::string fake_value_;
+ const base::StringValue fake_value_;
MockOwnershipService m_;
MessageLoop message_loop_;

Powered by Google App Engine
This is Rietveld 408576698