Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: chrome/browser/chromeos/login/signed_settings_helper.h

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments and rebased on a the current PART1 version. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/signed_settings_helper.h
diff --git a/chrome/browser/chromeos/login/signed_settings_helper.h b/chrome/browser/chromeos/login/signed_settings_helper.h
index 406ba7bb937ef396fc6dab07a6842ea9c638b769..0a80ef829a32ab4ab542e44c631bcbe492aafe91 100644
--- a/chrome/browser/chromeos/login/signed_settings_helper.h
+++ b/chrome/browser/chromeos/login/signed_settings_helper.h
@@ -8,6 +8,7 @@
#include <string>
+#include "base/values.h"
#include "chrome/browser/chromeos/login/signed_settings.h"
namespace enterprise_management {
@@ -42,13 +43,13 @@ class SignedSettingsHelper {
virtual void OnStorePropertyCompleted(
SignedSettings::ReturnCode code,
const std::string& name,
- const std::string& value) {}
+ const base::Value& value) {}
// Callback of RetrievePropertyOp.
virtual void OnRetrievePropertyCompleted(
SignedSettings::ReturnCode code,
const std::string& name,
- const std::string& value) {}
+ const base::Value& value) {}
// Callback of StorePolicyOp.
virtual void OnStorePolicyCompleted(
@@ -70,7 +71,7 @@ class SignedSettingsHelper {
bool add_to_whitelist,
Callback* callback) = 0;
virtual void StartStorePropertyOp(const std::string& name,
- const std::string& value,
+ const base::Value& value,
Callback* callback) = 0;
virtual void StartRetrieveProperty(const std::string& name,
Callback* callback) = 0;

Powered by Google App Engine
This is Rietveld 408576698