Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Unified Diff: chrome/browser/chromeos/login/signed_settings.h

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed comments and rebased on a the current PART1 version. Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/signed_settings.h
diff --git a/chrome/browser/chromeos/login/signed_settings.h b/chrome/browser/chromeos/login/signed_settings.h
index a423aaed70ccd5234a6ca2e29bce56d7e5f9abc2..56e1623201a6e2687c88c94c0ca1133eabd70b91 100644
--- a/chrome/browser/chromeos/login/signed_settings.h
+++ b/chrome/browser/chromeos/login/signed_settings.h
@@ -9,6 +9,7 @@
#include <string>
#include <vector>
+#include "base/values.h"
Denis Lagno 2011/10/13 13:43:10 nit: sort
pastarmovj 2011/10/26 15:44:59 Done.
#include "base/memory/ref_counted.h"
#include "chrome/browser/chromeos/login/owner_manager.h"
@@ -74,12 +75,12 @@ class SignedSettings : public base::RefCountedThreadSafe<SignedSettings>,
// one type can be in flight at a time.
static SignedSettings* CreateStorePropertyOp(
const std::string& name,
- const std::string& value,
+ const base::Value& value,
SignedSettings::Delegate<bool>* d);
static SignedSettings* CreateRetrievePropertyOp(
const std::string& name,
- SignedSettings::Delegate<std::string>* d);
+ SignedSettings::Delegate<const base::Value&>* d);
// These are both "policy" operations, and only one instance of
// one type can be in flight at a time.

Powered by Google App Engine
This is Rietveld 408576698