chrome/browser/chromeos/cros_settings_provider.cc - Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/cros_settings_provider.cc

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments and rebased on a the current PART1 version. Created 9 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/cros_settings_provider.h ('K') | « chrome/browser/chromeos/cros_settings_provider.h ('k') | chrome/browser/chromeos/login/mock_signed_settings_helper.h » ('j') | chrome/browser/chromeos/login/signed_settings.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/cros_settings_provider.cc

diff --git a/chrome/browser/chromeos/cros_settings_provider.cc b/chrome/browser/chromeos/cros_settings_provider.cc

index 95b59c0b20058f8f7b1abb935fa782d73d6d39f1..23f8acfc57aa17b4af463b1eee55b660c8a84714 100644

--- a/chrome/browser/chromeos/cros_settings_provider.cc

+++ b/chrome/browser/chromeos/cros_settings_provider.cc

@@ -12,7 +12,8 @@

namespace chromeos {

-void CrosSettingsProvider::Set(const std::string& path, Value* value) {

+void CrosSettingsProvider::Set(const std::string& path,

+ const base::Value& value) {

// We don't allow changing any of the cros settings without prefix

// "cros.session." in the guest mode.

// It should not reach here from UI in the guest mode, but just in case.