Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Side by Side Diff: chrome/browser/ui/webui/options/chromeos/system_settings_provider.h

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed the nits and rebased on ToT (which now has PART1 in). Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_CHROMEOS_SYSTEM_SETTINGS_PROVIDER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_OPTIONS_CHROMEOS_SYSTEM_SETTINGS_PROVIDER_H_
6 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_CHROMEOS_SYSTEM_SETTINGS_PROVIDER_H_ 6 #define CHROME_BROWSER_UI_WEBUI_OPTIONS_CHROMEOS_SYSTEM_SETTINGS_PROVIDER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 23 matching lines...) Expand all
34 virtual bool HandlesSetting(const std::string& path) const OVERRIDE; 34 virtual bool HandlesSetting(const std::string& path) const OVERRIDE;
35 35
36 // Overridden from TimezoneSettings::Observer: 36 // Overridden from TimezoneSettings::Observer:
37 virtual void TimezoneChanged(const icu::TimeZone& timezone) OVERRIDE; 37 virtual void TimezoneChanged(const icu::TimeZone& timezone) OVERRIDE;
38 38
39 // Creates the map of timezones used by the options page. 39 // Creates the map of timezones used by the options page.
40 base::ListValue* GetTimezoneList(); 40 base::ListValue* GetTimezoneList();
41 41
42 private: 42 private:
43 // CrosSettingsProvider overrides. 43 // CrosSettingsProvider overrides.
44 virtual void DoSet(const std::string& path, base::Value* in_value) OVERRIDE; 44 virtual void DoSet(const std::string& path,
45 const base::Value& in_value) OVERRIDE;
45 46
46 // Gets timezone name. 47 // Gets timezone name.
47 static string16 GetTimezoneName(const icu::TimeZone& timezone); 48 static string16 GetTimezoneName(const icu::TimeZone& timezone);
48 49
49 // Gets timezone ID which is also used as timezone pref value. 50 // Gets timezone ID which is also used as timezone pref value.
50 static string16 GetTimezoneID(const icu::TimeZone& timezone); 51 static string16 GetTimezoneID(const icu::TimeZone& timezone);
51 52
52 // Gets timezone object from its id. 53 // Gets timezone object from its id.
53 const icu::TimeZone* GetTimezone(const string16& timezone_id); 54 const icu::TimeZone* GetTimezone(const string16& timezone_id);
54 55
(...skipping 10 matching lines...) Expand all
65 std::vector<icu::TimeZone*> timezones_; 66 std::vector<icu::TimeZone*> timezones_;
66 // TODO(pastarmovj): This will be cached in the local_state PrefStore soon. 67 // TODO(pastarmovj): This will be cached in the local_state PrefStore soon.
67 mutable scoped_ptr<base::StringValue> system_timezone_; 68 mutable scoped_ptr<base::StringValue> system_timezone_;
68 69
69 DISALLOW_COPY_AND_ASSIGN(SystemSettingsProvider); 70 DISALLOW_COPY_AND_ASSIGN(SystemSettingsProvider);
70 }; 71 };
71 72
72 } // namespace chromeos 73 } // namespace chromeos
73 74
74 #endif // CHROME_BROWSER_UI_WEBUI_OPTIONS_CHROMEOS_SYSTEM_SETTINGS_PROVIDER_H_ 75 #endif // CHROME_BROWSER_UI_WEBUI_OPTIONS_CHROMEOS_SYSTEM_SETTINGS_PROVIDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698