Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: chrome/browser/chromeos/cros_settings_provider.h

Issue 8091002: PART2: Make SignedSettings use proper Value types instead of string all around the place. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed the nits and rebased on ToT (which now has PART1 in). Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_CROS_SETTINGS_PROVIDER_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_CROS_SETTINGS_PROVIDER_H_
6 #define CHROME_BROWSER_CHROMEOS_CROS_SETTINGS_PROVIDER_H_ 6 #define CHROME_BROWSER_CHROMEOS_CROS_SETTINGS_PROVIDER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 11
12 namespace base { 12 namespace base {
13 class Value; 13 class Value;
14 } 14 }
15 15
16 namespace chromeos { 16 namespace chromeos {
17 17
18 class CrosSettingsProvider { 18 class CrosSettingsProvider {
19 public: 19 public:
20 virtual ~CrosSettingsProvider() {} 20 virtual ~CrosSettingsProvider() {}
21 21
22 // Sets |in_value| to given |path| in cros settings. 22 // Sets |in_value| to given |path| in cros settings.
23 // Note that this takes ownership of |in_value|. 23 void Set(const std::string& path, const base::Value& in_value);
24 void Set(const std::string& path, base::Value* in_value);
25 24
26 // Gets settings value of given |path| to |out_value|. 25 // Gets settings value of given |path| to |out_value|.
27 virtual const base::Value* Get(const std::string& path) const = 0; 26 virtual const base::Value* Get(const std::string& path) const = 0;
28 27
29 // Starts a fetch from the trusted store for the value of |path|. It will 28 // Starts a fetch from the trusted store for the value of |path| if not loaded
30 // call the |callback| function upon completion. 29 // yet. It will call the |callback| function upon completion if a new fetch
30 // was needed in which case the return value is false. Else it will return
31 // true and won't call the |callback|.
31 virtual bool GetTrusted(const std::string& path, 32 virtual bool GetTrusted(const std::string& path,
32 const base::Closure& callback) const = 0; 33 const base::Closure& callback) const = 0;
33 34
34 // Gets the namespace prefix provided by this provider 35 // Gets the namespace prefix provided by this provider
35 virtual bool HandlesSetting(const std::string& path) const = 0; 36 virtual bool HandlesSetting(const std::string& path) const = 0;
36 37
37 private: 38 private:
38 // Does the real job for Set(). 39 // Does the real job for Set().
39 virtual void DoSet(const std::string& path, base::Value* in_value) = 0; 40 virtual void DoSet(const std::string& path,
41 const base::Value& in_value) = 0;
40 }; 42 };
41 43
42 } // namespace chromeos 44 } // namespace chromeos
43 45
44 #endif // CHROME_BROWSER_CHROMEOS_CROS_SETTINGS_PROVIDER_H_ 46 #endif // CHROME_BROWSER_CHROMEOS_CROS_SETTINGS_PROVIDER_H_
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/cros_settings.cc ('k') | chrome/browser/chromeos/cros_settings_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698