PART2: Make SignedSettings use proper Value types instead of string all around the place.

chrome/browser/chromeos/proxy_config_service_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/proxy_config_service_impl.h"
 
 #include <ostream>
 
 #include "base/json/json_value_serializer.h"
 #include "base/logging.h"
@@ skipping 508 matching lines @@
     network = CrosLibrary::Get()->GetNetworkLibrary()->FindNetworkByPath(
         active_network_);
     if (!network)
       LOG(ERROR) << "can't find requested network " << active_network_;
   }
   DetermineEffectiveConfig(network, true);
 }
 
 void ProxyConfigServiceImpl::OnSettingsOpCompleted(
     SignedSettings::ReturnCode code,
-    std::string value) {
+    const base::Value* value) {
+  // We assume ownership here to make sure this gets deleted no matter where
+  // this function ends.
+  scoped_ptr<const base::Value> own_value(value);
+
   retrieve_property_op_ = NULL;
   if (code != SignedSettings::SUCCESS) {
     LOG(WARNING) << this << ": Error retrieving proxy setting from device";
     device_config_.clear();
     return;
   }
-  VLOG(1) << this << ": Retrieved proxy setting from device, value=["
-          << value << "]";
+  std::string policy_value;
+  value->GetAsString(&policy_value);
+  VLOG(1) << "Retrieved proxy setting from device, value=["
+          << policy_value << "]";
   ProxyConfig device_config;
-  if (!device_config.DeserializeForDevice(value) ||
+  if (!device_config.DeserializeForDevice(policy_value) ||
       !device_config.SerializeForNetwork(&device_config_)) {
     LOG(WARNING) << "Can't deserialize device setting or serialize for network";
     device_config_.clear();
     return;
   }
   if (!active_network_.empty()) {
     VLOG(1) << this << ": try migrating device config to " << active_network_;
     SetProxyConfigForNetwork(active_network_, device_config_, true);
   }
 }
@@ skipping 261 matching lines @@
     }
   }
 }
 
 void ProxyConfigServiceImpl::ResetUICache() {
   current_ui_network_.clear();
   current_ui_config_ = ProxyConfig();
 }
 
 }  // namespace chromeos