PART2: Make SignedSettings use proper Value types instead of string all around the place.

chrome/browser/chromeos/login/signed_settings_helper.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_SIGNED_SETTINGS_HELPER_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_SIGNED_SETTINGS_HELPER_H_
 #pragma once
 
 #include <string>
 
+#include "base/values.h"

[Mattias Nissler (ping if slow), 2011/11/18 14:24:42]

forward decl?

[pastarmovj, 2011/11/22 12:13:58]

Done.

 #include "chrome/browser/chromeos/login/signed_settings.h"
 
 namespace enterprise_management {
 class PolicyFetchResponse;
 }  // namespace enterprise_management
 namespace em = enterprise_management;
 namespace chromeos {
 
 class SignedSettings;
 
@@ skipping 14 matching lines @@
         SignedSettings::ReturnCode code, const std::string& email) {}
 
     // Callback of WhitelistOp that removes |email| to the whitelist.
     virtual void OnUnwhitelistCompleted(
         SignedSettings::ReturnCode code, const std::string& email) {}
 
     // Callback of StorePropertyOp.
     virtual void OnStorePropertyCompleted(
         SignedSettings::ReturnCode code,
         const std::string& name,
-        const std::string& value) {}
+        const base::Value& value) {}
 
     // Callback of RetrievePropertyOp.
     virtual void OnRetrievePropertyCompleted(
         SignedSettings::ReturnCode code,
         const std::string& name,
-        const std::string& value) {}
+        const base::Value* value) {}
 
     // Callback of StorePolicyOp.
     virtual void OnStorePolicyCompleted(
         SignedSettings::ReturnCode code) {}
 
     // Callback of RetrievePolicyOp.
     virtual void OnRetrievePolicyCompleted(
         SignedSettings::ReturnCode code,
         const em::PolicyFetchResponse& policy) {}
   };
 
   // Class factory
   static SignedSettingsHelper* Get();
 
   // Functions to start signed settings ops.
   virtual void StartCheckWhitelistOp(const std::string& email,
                                      Callback* callback) = 0;
   virtual void StartWhitelistOp(const std::string& email,
                                 bool add_to_whitelist,
                                 Callback* callback) = 0;
   virtual void StartStorePropertyOp(const std::string& name,
-                                    const std::string& value,
+                                    const base::Value& value,
                                     Callback* callback) = 0;
   virtual void StartRetrieveProperty(const std::string& name,
                                      Callback* callback) = 0;
   virtual void StartStorePolicyOp(const em::PolicyFetchResponse& policy,
                                   Callback* callback) = 0;
   virtual void StartRetrievePolicyOp(Callback* callback) = 0;
 
   // Cancels all pending calls of given callback.
   virtual void CancelCallback(Callback* callback) = 0;
 
@@ skipping 13 matching lines @@
  protected:
   SignedSettingsHelper() : test_delegate_(NULL) {
   }
 
   TestDelegate* test_delegate_;
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_SIGNED_SETTINGS_HELPER_H_