PART2: Make SignedSettings use proper Value types instead of string all around the place.

chrome/browser/chromeos/login/signed_settings.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_SIGNED_SETTINGS_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_SIGNED_SETTINGS_H_
 #pragma once
 
 #include <string>
 #include <vector>
 
 #include "base/memory/ref_counted.h"
+#include "base/values.h"

[Mattias Nissler (ping if slow), 2011/11/18 14:24:42]

forward declaration should suffice?

[pastarmovj, 2011/11/22 12:13:58]

Done.

 #include "chrome/browser/chromeos/login/owner_manager.h"
 
 // There are two categories of operations that can be performed on the
 // Chrome OS owner-signed settings store:
 // 1) doing stuff to the whitelist (adding/removing/checking)
 // 2) Storing/Retrieving arbitrary name=value pairs
 //
 // Unfortunately, it is currently a limitation that only one of each
 // category can be in-flight at a time.  You can be doing exactly one thing
 // to the whitelist, and exactly one thing to the property store at a time.
@@ skipping 44 matching lines @@
       SignedSettings::Delegate<bool>* d);
 
   static SignedSettings* CreateWhitelistOp(const std::string& email,
                                            bool add_to_whitelist,
                                            SignedSettings::Delegate<bool>* d);
 
   // These are both "property" operations, and only one instance of
   // one type can be in flight at a time.
   static SignedSettings* CreateStorePropertyOp(
       const std::string& name,
-      const std::string& value,
+      const base::Value& value,
       SignedSettings::Delegate<bool>* d);
 
   static SignedSettings* CreateRetrievePropertyOp(
       const std::string& name,
-      SignedSettings::Delegate<std::string>* d);
+      SignedSettings::Delegate<const base::Value*>* d);
 
   // These are both "policy" operations, and only one instance of
   // one type can be in flight at a time.
   static SignedSettings* CreateStorePolicyOp(
       em::PolicyFetchResponse* policy,
       SignedSettings::Delegate<bool>* d);
 
   static SignedSettings* CreateRetrievePolicyOp(
       SignedSettings::Delegate<const em::PolicyFetchResponse&>* d);
 
@@ skipping 41 matching lines @@
   static const char kDevicePolicyType[];
 
   scoped_ptr<Relay> relay_;
   scoped_refptr<SignedSettings> polfetcher_;
   DISALLOW_COPY_AND_ASSIGN(SignedSettings);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_SIGNED_SETTINGS_H_