PART2: Make SignedSettings use proper Value types instead of string all around the place.

chrome/browser/profiles/profile_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl.h"
 
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
 #include "base/environment.h"
 #include "base/file_path.h"
@@ skipping 200 matching lines @@
     *max_size = 0;
   }
 }
 
 FilePath GetCachePath(const FilePath& base) {
   return base.Append(chrome::kCacheDirname);
 }
 
 FilePath GetMediaCachePath(const FilePath& base) {
   return base.Append(chrome::kMediaCacheDirname);
 }

[Mattias Nissler (ping if slow), 2011/10/07 11:02:57]

unrelated?

[pastarmovj, 2011/10/13 11:25:06]

Yes. Cleared.

 
-void DoInstallDefaultAppsOnUIThread(const FilePath& profile_path,
-                                    const std::list<FilePath>& crx_path_list) {
-  Profile* profile =
-      g_browser_process->profile_manager()->GetProfileByPath(profile_path);
-  if (profile) {
-    ExtensionService* extension_service = profile->GetExtensionService();
-    for (std::list<FilePath>::const_iterator iter = crx_path_list.begin();
-         iter != crx_path_list.end(); ++iter) {
-      scoped_refptr<CrxInstaller> crx_installer =
-          extension_service->MakeCrxInstaller(NULL);
-      crx_installer->set_allow_silent_install(true);
-      crx_installer->set_delete_source(false);
-      crx_installer->set_install_cause(extension_misc::INSTALL_CAUSE_UPDATE);
-      crx_installer->InstallCrx(*iter);
-    }
-  }
-}
-
-void InstallDefaultApps(const FilePath& profile_path) {
-  FilePath apps_dir;
-  FilePath file;
-  std::list<FilePath> crx_path_list;
-
-  if (PathService::Get(chrome::DIR_DEFAULT_APPS, &apps_dir)) {
-    file_util::FileEnumerator file_enumerator(apps_dir, false,
-        file_util::FileEnumerator::FILES);
-    while (!(file = file_enumerator.Next()).value().empty()) {
-      if (LowerCaseEqualsASCII(file.Extension(), ".crx"))
-        crx_path_list.push_back(file);
-    }
-  }
-  // No need to post the task if nothing was there to install.
-  if (!crx_path_list.size())
-    return;
-
-  // Finish the install on the UI thread.
-  BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
-                          base::Bind(&DoInstallDefaultAppsOnUIThread,
-                                     profile_path, crx_path_list));
-}
-
 // Simple task to log the size of the current profile.
 class ProfileSizeTask : public Task {
  public:
   explicit ProfileSizeTask(const FilePath& path) : path_(path) {}
   virtual ~ProfileSizeTask() {}
 
   virtual void Run();
  private:
   FilePath path_;
 };
@@ skipping 1547 matching lines @@
 SpellCheckProfile* ProfileImpl::GetSpellCheckProfile() {
   if (!spellcheck_profile_.get())
     spellcheck_profile_.reset(new SpellCheckProfile());
   return spellcheck_profile_.get();
 }
 
 void ProfileImpl::SetDownloadManagerDelegate(
     ChromeDownloadManagerDelegate* delegate) {
   download_manager_delegate_ = delegate;
 }