PART2: Make SignedSettings use proper Value types instead of string all around the place.

base/values.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/values.h"
 
 #include <algorithm>
 
 #include "base/float_util.h"
 #include "base/logging.h"
@@ skipping 867 matching lines @@
   DCHECK(in_value);
   if (index > list_.size())
     return false;
 
   list_.insert(list_.begin() + index, in_value);
   return true;
 }
 
 ListValue::const_iterator ListValue::Find(const Value& value) const {
   return std::find_if(list_.begin(), list_.end(), ValueEquals(&value));
 }

[Mattias Nissler (ping if slow), 2011/10/07 11:02:57]

This is obsolete.

[pastarmovj, 2011/10/13 11:25:06]

Yes, rebasing artifact. Removed.

 
-int ListValue::Find(const Value& value) const {
-  for (ValueVector::const_iterator i(list_.begin()); i != list_.end(); ++i) {
-    if ((*i)->Equals(&value)) {
-      return i - list_.begin();
-    }
-  }
-  return -1;
-}
-
 bool ListValue::GetAsList(ListValue** out_value) {
   if (out_value)
     *out_value = this;
   return true;
 }
 
 bool ListValue::GetAsList(const ListValue** out_value) const {
   if (out_value)
     *out_value = this;
   return true;
@@ skipping 24 matching lines @@
   if (lhs_it != end() || rhs_it != other_list->end())
     return false;
 
   return true;
 }
 
 ValueSerializer::~ValueSerializer() {
 }
 
 }  // namespace base