PART2: Make SignedSettings use proper Value types instead of string all around the place.

chrome/browser/chromeos/proxy_config_service_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_PROXY_CONFIG_SERVICE_IMPL_H_
 #define CHROME_BROWSER_CHROMEOS_PROXY_CONFIG_SERVICE_IMPL_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 17 matching lines @@
 //   net::ProxyConfigService interface by fowarding the methods to this class
 // - retrieves initial system proxy configuration from cros settings persisted
 //   on chromeos device from chromeos revisions before migration to flimflam,
 // - persists proxy setting per network in flimflim
 // - provides network stack with latest proxy configuration for currently
 //   active network for use on IO thread
 // - provides UI with methods to retrieve and modify proxy configuration for
 //   any network (either currently active or non-active) on UI thread
 class ProxyConfigServiceImpl
     : public base::RefCountedThreadSafe<ProxyConfigServiceImpl>,
-      public SignedSettings::Delegate<std::string>,
+      public SignedSettings::Delegate<const base::Value&>,
       public NetworkLibrary::NetworkManagerObserver,
       public NetworkLibrary::NetworkObserver {
  public:
   // ProxyConfigServiceImpl is created on the UI thread in
   // chrome/browser/net/proxy_service_factory.cc::CreateProxyConfigService
   // via BrowserProcess::chromeos_proxy_config_service_impl, and stored in
   // g_browser_process as a scoped_refptr (because it's RefCountedThreadSafe).
   //
   // Past that point, it can be accessed from the IO or UI threads.
   //
@@ skipping 176 matching lines @@
   bool UISetProxyConfigToPACScript(const GURL& pac_url);
   bool UISetProxyConfigToSingleProxy(const net::ProxyServer& server);
   // |scheme| is one of "http", "https", "ftp" or "socks".
   bool UISetProxyConfigToProxyPerScheme(const std::string& scheme,
                                         const net::ProxyServer& server);
   // Only valid for MODE_SINGLE_PROXY or MODE_PROXY_PER_SCHEME.
   bool UISetProxyConfigBypassRules(const net::ProxyBypassRules& bypass_rules);
 
   // Implementation for SignedSettings::Delegate
   virtual void OnSettingsOpCompleted(SignedSettings::ReturnCode code,
-                                     std::string value);
+                                     const base::Value& value) OVERRIDE;
 
   // NetworkLibrary::NetworkManagerObserver implementation.
-  virtual void OnNetworkManagerChanged(NetworkLibrary* cros);
+  virtual void OnNetworkManagerChanged(NetworkLibrary* cros) OVERRIDE;
 
   // NetworkLibrary::NetworkObserver implementation.
-  virtual void OnNetworkChanged(NetworkLibrary* cros, const Network* network);
+  virtual void OnNetworkChanged(NetworkLibrary* cros,
+                                const Network* network) OVERRIDE;
 
 #if defined(UNIT_TEST)
   void SetTesting() {
     testing_ = true;
     active_network_ = "test";
     UIMakeActiveNetworkCurrent();
   }
 #endif  // defined(UNIT_TEST)
 
  private:
@@ skipping 84 matching lines @@
 
   // Operation to retrieve proxy setting from device.
   scoped_refptr<SignedSettings> retrieve_property_op_;
 
   DISALLOW_COPY_AND_ASSIGN(ProxyConfigServiceImpl);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_PROXY_CONFIG_SERVICE_IMPL_H_