Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: pylibs/buildbot/status/status_push.py

Issue 809001: Rename a few variables and greatly reduce the amount of data sent for steps* events (Closed)
Patch Set: Rebase against trunk and fix the unit test again Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylibs/buildbot/status/builder.py ('k') | pylibs/buildbot/test/test_status_push.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylibs/buildbot/status/status_push.py
diff --git a/pylibs/buildbot/status/status_push.py b/pylibs/buildbot/status/status_push.py
index 45318acc80148465d185872426cb41ffae530dac..e3c407b0456522bbcd6bf0ad680a07f7c0d3546c 100644
--- a/pylibs/buildbot/status/status_push.py
+++ b/pylibs/buildbot/status/status_push.py
@@ -233,30 +233,46 @@ class StatusPush(StatusReceiverMultiService):
self.push('buildETAUpdate', build=build, ETA=ETA)
def stepStarted(self, build, step):
- self.push('stepStarted', build=build, step=step)
+ self.push('stepStarted',
+ properties=build.getProperties().asList(),
+ step=step)
def stepTextChanged(self, build, step, text):
- self.push('stepTextChanged', build=build, step=step, text=text)
+ self.push('stepTextChanged',
+ properties=build.getProperties().asList(),
+ step=step,
+ text=text)
def stepText2Changed(self, build, step, text2):
- self.push('stepText2Changed', build=build, step=step, text2=text2)
+ self.push('stepText2Changed',
+ properties=build.getProperties().asList(),
+ step=step,
+ text2=text2)
def stepETAUpdate(self, build, step, ETA, expectations):
- self.push('stepETAUpdate', build=build, step=step, ETA=ETA,
+ self.push('stepETAUpdate',
+ properties=build.getProperties().asList(),
+ step=step,
+ ETA=ETA,
expectations=expectations)
def logStarted(self, build, step, log):
- self.push('logStarted', build=build, step=step, log=log)
+ self.push('logStarted',
+ properties=build.getProperties().asList(),
+ step=step)
def logFinished(self, build, step, log):
- self.push('logFinished', build=build, step=step)
+ self.push('logFinished',
+ properties=build.getProperties().asList(),
+ step=step)
def stepFinished(self, build, step, results):
- self.push('stepFinished', build=build, step=step, results=results)
+ self.push('stepFinished',
+ properties=build.getProperties().asList(),
+ step=step)
def buildFinished(self, builderName, build, results):
- self.push('buildFinished', builderName=builderName, build=build,
- results=results)
+ self.push('buildFinished', build=build)
def builderRemoved(self, builderName):
self.push('buildedRemoved', builderName=builderName)
« no previous file with comments | « pylibs/buildbot/status/builder.py ('k') | pylibs/buildbot/test/test_status_push.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698