Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 8086017: add more appcache_exports needed for test_shell_tests (Closed)

Created:
9 years, 2 months ago by Dirk Pranke
Modified:
9 years, 2 months ago
Reviewers:
michaeln
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Add more appcache_exports needed for test_shell_tests when we start linking appcache as a DLL. R=michaeln@chromium.org BUG=90442 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103562

Patch Set 1 #

Patch Set 2 : add missing appcache_export #includes #

Patch Set 3 : clean up nits #

Patch Set 4 : fix weird merge issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -41 lines) Patch
M webkit/appcache/appcache.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_database.h View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M webkit/appcache/appcache_disk_cache.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M webkit/appcache/appcache_group.h View 1 2 3 4 chunks +6 lines, -7 lines 0 comments Download
M webkit/appcache/appcache_host.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_quota_client.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_request_handler.h View 2 chunks +6 lines, -3 lines 0 comments Download
M webkit/appcache/appcache_response.h View 6 chunks +6 lines, -6 lines 0 comments Download
M webkit/appcache/appcache_storage.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/appcache/appcache_update_job.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/appcache/appcache_url_request_job.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/appcache/appcache_working_set.h View 2 chunks +2 lines, -1 line 0 comments Download
M webkit/appcache/manifest_parser.h View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Dirk Pranke
9 years, 2 months ago (2011-09-30 19:45:59 UTC) #1
michaeln
9 years, 2 months ago (2011-09-30 21:47:16 UTC) #2
lgtm

bummer that "what to export" != "what should be public" given that unit tests
consume what's in there in ways no other consumer should

Powered by Google App Engine
This is Rietveld 408576698