Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 8086002: Add metrics to help measure effects of installing default apps in a profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Remove DCHECK, since this does happen in unit test AvatarMenuModelTest.InitialCreation Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/crx_installer.cc
===================================================================
--- chrome/browser/extensions/crx_installer.cc (revision 103881)
+++ chrome/browser/extensions/crx_installer.cc (working copy)
@@ -9,6 +9,7 @@
#include "base/file_util.h"
#include "base/lazy_instance.h"
+#include "base/metrics/field_trial.h"
#include "base/metrics/histogram.h"
#include "base/path_service.h"
#include "base/scoped_temp_dir.h"
@@ -22,6 +23,7 @@
#include "chrome/browser/browser_process.h"
#include "chrome/browser/extensions/convert_user_script.h"
#include "chrome/browser/extensions/convert_web_app.h"
+#include "chrome/browser/extensions/default_apps_trial.h"
#include "chrome/browser/extensions/extension_error_reporter.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/shell_integration.h"
@@ -544,6 +546,14 @@
if (install_cause() == extension_misc::INSTALL_CAUSE_USER_DOWNLOAD) {
UserMetrics::RecordAction(
UserMetricsAction("Extensions.ExtensionInstalled"));
+
+ static bool default_apps_trial_exists =
+ base::FieldTrialList::TrialExists(kDefaultAppsTrial_Name);
+ if (default_apps_trial_exists) {
+ UserMetrics::RecordComputedAction(
+ base::FieldTrial::MakeName("Extensions.ExtensionInstalled",
+ kDefaultAppsTrial_Name));
+ }
}
if (!BrowserThread::PostTask(
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service.cc » ('j') | chrome/browser/extensions/extension_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698