Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/ui/webui/ntp/new_tab_page_handler.h

Issue 8086002: Add metrics to help measure effects of installing default apps in a profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Addressing review comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/new_tab_page_handler.h
===================================================================
--- chrome/browser/ui/webui/ntp/new_tab_page_handler.h (revision 105209)
+++ chrome/browser/ui/webui/ntp/new_tab_page_handler.h (working copy)
@@ -19,6 +19,7 @@
virtual ~NewTabPageHandler() {}
// WebUIMessageHandler implementation.
+ virtual WebUIMessageHandler* Attach(WebUI* web_ui) OVERRIDE;
virtual void RegisterMessages() OVERRIDE;
// Callback for "closeNotificationPromo".
@@ -52,11 +53,13 @@
// The lower 10 bits of kNTPShownPage are used for the index within the page
// group, and the rest of the bits are used for the page group ID (defined
// here).
+ static const int kPageIdOffset = 10;
enum {
- INDEX_MASK = (1 << 10) - 1,
- MOST_VISITED_PAGE_ID = 1 << 10,
- APPS_PAGE_ID = 2 << 10,
- BOOKMARKS_PAGE_ID = 3 << 10,
+ INDEX_MASK = (1 << kPageIdOffset) - 1,
+ MOST_VISITED_PAGE_ID = 1 << kPageIdOffset,
+ APPS_PAGE_ID = 2 << kPageIdOffset,
+ BOOKMARKS_PAGE_ID = 3 << kPageIdOffset,
+ LAST_PAGE_ID = BOOKMARKS_PAGE_ID
};
// Helper to send out promo resource change notification.

Powered by Google App Engine
This is Rietveld 408576698