Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Side by Side Diff: chrome/browser/extensions/extension_service.cc

Issue 8086002: Add metrics to help measure effects of installing default apps in a profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Remove DCHECK, since this does happen in unit test AvatarMenuModelTest.InitialCreation Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/profiles/profile_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_service.h" 5 #include "chrome/browser/extensions/extension_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <set> 8 #include <set>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/command_line.h" 11 #include "base/command_line.h"
12 #include "base/file_util.h" 12 #include "base/file_util.h"
13 #include "base/logging.h" 13 #include "base/logging.h"
14 #include "base/metrics/field_trial.h"
14 #include "base/metrics/histogram.h" 15 #include "base/metrics/histogram.h"
15 #include "base/path_service.h" 16 #include "base/path_service.h"
16 #include "base/stl_util.h" 17 #include "base/stl_util.h"
17 #include "base/string16.h" 18 #include "base/string16.h"
18 #include "base/string_number_conversions.h" 19 #include "base/string_number_conversions.h"
19 #include "base/string_util.h" 20 #include "base/string_util.h"
20 #include "base/stringprintf.h" 21 #include "base/stringprintf.h"
21 #include "base/threading/thread_restrictions.h" 22 #include "base/threading/thread_restrictions.h"
22 #include "base/time.h" 23 #include "base/time.h"
23 #include "base/utf_string_conversions.h" 24 #include "base/utf_string_conversions.h"
24 #include "base/values.h" 25 #include "base/values.h"
25 #include "base/version.h" 26 #include "base/version.h"
26 #include "chrome/browser/browser_process.h" 27 #include "chrome/browser/browser_process.h"
27 #include "chrome/browser/chrome_plugin_service_filter.h" 28 #include "chrome/browser/chrome_plugin_service_filter.h"
28 #include "chrome/browser/extensions/apps_promo.h" 29 #include "chrome/browser/extensions/apps_promo.h"
29 #include "chrome/browser/extensions/crx_installer.h" 30 #include "chrome/browser/extensions/crx_installer.h"
31 #include "chrome/browser/extensions/default_apps_trial.h"
30 #include "chrome/browser/extensions/extension_accessibility_api.h" 32 #include "chrome/browser/extensions/extension_accessibility_api.h"
31 #include "chrome/browser/extensions/extension_bookmarks_module.h" 33 #include "chrome/browser/extensions/extension_bookmarks_module.h"
32 #include "chrome/browser/extensions/extension_browser_event_router.h" 34 #include "chrome/browser/extensions/extension_browser_event_router.h"
33 #include "chrome/browser/extensions/extension_cookies_api.h" 35 #include "chrome/browser/extensions/extension_cookies_api.h"
34 #include "chrome/browser/extensions/extension_data_deleter.h" 36 #include "chrome/browser/extensions/extension_data_deleter.h"
35 #include "chrome/browser/extensions/extension_downloads_api.h" 37 #include "chrome/browser/extensions/extension_downloads_api.h"
36 #include "chrome/browser/extensions/extension_error_reporter.h" 38 #include "chrome/browser/extensions/extension_error_reporter.h"
37 #include "chrome/browser/extensions/extension_history_api.h" 39 #include "chrome/browser/extensions/extension_history_api.h"
38 #include "chrome/browser/extensions/extension_host.h" 40 #include "chrome/browser/extensions/extension_host.h"
39 #include "chrome/browser/extensions/extension_input_ime_api.h" 41 #include "chrome/browser/extensions/extension_input_ime_api.h"
(...skipping 916 matching lines...) Expand 10 before | Expand all | Expand 10 after
956 if (sync_bundle && sync_bundle->HasExtensionId(extension_id)) { 958 if (sync_bundle && sync_bundle->HasExtensionId(extension_id)) {
957 sync_bundle->sync_processor->ProcessSyncChanges( 959 sync_bundle->sync_processor->ProcessSyncChanges(
958 FROM_HERE, SyncChangeList(1, sync_change)); 960 FROM_HERE, SyncChangeList(1, sync_change));
959 sync_bundle->synced_extensions.erase(extension_id); 961 sync_bundle->synced_extensions.erase(extension_id);
960 } 962 }
961 963
962 // Track the uninstallation. 964 // Track the uninstallation.
963 UserMetrics::RecordAction( 965 UserMetrics::RecordAction(
964 UserMetricsAction("Extensions.ExtensionUninstalled")); 966 UserMetricsAction("Extensions.ExtensionUninstalled"));
965 967
968 static bool default_apps_trial_exists =
969 base::FieldTrialList::TrialExists(kDefaultAppsTrial_Name);
970 if (default_apps_trial_exists) {
971 UserMetrics::RecordComputedAction(
jar (doing other things) 2011/10/05 17:42:16 I suspect you'd be much better off using a histogr
Roger Tawa OOO till Jul 10th 2011/10/12 14:46:22 Done.
972 base::FieldTrial::MakeName("Extensions.ExtensionUninstalled",
973 kDefaultAppsTrial_Name));
974 }
975
966 return true; 976 return true;
967 } 977 }
968 978
969 void ExtensionService::ClearExtensionData(const std::string& extension_id, 979 void ExtensionService::ClearExtensionData(const std::string& extension_id,
970 const GURL& storage_url, 980 const GURL& storage_url,
971 bool is_storage_isolated) { 981 bool is_storage_isolated) {
972 scoped_refptr<ExtensionDataDeleter> deleter(new ExtensionDataDeleter( 982 scoped_refptr<ExtensionDataDeleter> deleter(new ExtensionDataDeleter(
973 profile_, extension_id, storage_url, is_storage_isolated)); 983 profile_, extension_id, storage_url, is_storage_isolated));
974 deleter->StartDeleting(); 984 deleter->StartDeleting();
975 } 985 }
(...skipping 1924 matching lines...) Expand 10 before | Expand all | Expand 10 after
2900 2910
2901 ExtensionService::NaClModuleInfoList::iterator 2911 ExtensionService::NaClModuleInfoList::iterator
2902 ExtensionService::FindNaClModule(const GURL& url) { 2912 ExtensionService::FindNaClModule(const GURL& url) {
2903 for (NaClModuleInfoList::iterator iter = nacl_module_list_.begin(); 2913 for (NaClModuleInfoList::iterator iter = nacl_module_list_.begin();
2904 iter != nacl_module_list_.end(); ++iter) { 2914 iter != nacl_module_list_.end(); ++iter) {
2905 if (iter->url == url) 2915 if (iter->url == url)
2906 return iter; 2916 return iter;
2907 } 2917 }
2908 return nacl_module_list_.end(); 2918 return nacl_module_list_.end();
2909 } 2919 }
OLDNEW
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | chrome/browser/profiles/profile_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698