Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Side by Side Diff: chrome/browser/extensions/extension_service.cc

Issue 8086002: Add metrics to help measure effects of installing default apps in a profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Addressing review comments Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_service.h" 5 #include "chrome/browser/extensions/extension_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <set> 8 #include <set>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/callback.h" 11 #include "base/callback.h"
12 #include "base/command_line.h" 12 #include "base/command_line.h"
13 #include "base/file_util.h" 13 #include "base/file_util.h"
14 #include "base/json/json_value_serializer.h" 14 #include "base/json/json_value_serializer.h"
15 #include "base/logging.h" 15 #include "base/logging.h"
16 #include "base/metrics/field_trial.h"
16 #include "base/metrics/histogram.h" 17 #include "base/metrics/histogram.h"
17 #include "base/path_service.h" 18 #include "base/path_service.h"
18 #include "base/stl_util.h" 19 #include "base/stl_util.h"
19 #include "base/string16.h" 20 #include "base/string16.h"
20 #include "base/string_number_conversions.h" 21 #include "base/string_number_conversions.h"
21 #include "base/string_util.h" 22 #include "base/string_util.h"
22 #include "base/stringprintf.h" 23 #include "base/stringprintf.h"
23 #include "base/threading/thread_restrictions.h" 24 #include "base/threading/thread_restrictions.h"
24 #include "base/time.h" 25 #include "base/time.h"
25 #include "base/utf_string_conversions.h" 26 #include "base/utf_string_conversions.h"
26 #include "base/values.h" 27 #include "base/values.h"
27 #include "base/version.h" 28 #include "base/version.h"
28 #include "chrome/browser/browser_process.h" 29 #include "chrome/browser/browser_process.h"
29 #include "chrome/browser/chrome_plugin_service_filter.h" 30 #include "chrome/browser/chrome_plugin_service_filter.h"
30 #include "chrome/browser/extensions/app_notification_manager.h" 31 #include "chrome/browser/extensions/app_notification_manager.h"
31 #include "chrome/browser/extensions/apps_promo.h" 32 #include "chrome/browser/extensions/apps_promo.h"
32 #include "chrome/browser/extensions/crx_installer.h" 33 #include "chrome/browser/extensions/crx_installer.h"
34 #include "chrome/browser/extensions/default_apps_trial.h"
33 #include "chrome/browser/extensions/extension_accessibility_api.h" 35 #include "chrome/browser/extensions/extension_accessibility_api.h"
34 #include "chrome/browser/extensions/extension_bookmarks_module.h" 36 #include "chrome/browser/extensions/extension_bookmarks_module.h"
35 #include "chrome/browser/extensions/extension_browser_event_router.h" 37 #include "chrome/browser/extensions/extension_browser_event_router.h"
36 #include "chrome/browser/extensions/extension_cookies_api.h" 38 #include "chrome/browser/extensions/extension_cookies_api.h"
37 #include "chrome/browser/extensions/extension_data_deleter.h" 39 #include "chrome/browser/extensions/extension_data_deleter.h"
38 #include "chrome/browser/extensions/extension_downloads_api.h" 40 #include "chrome/browser/extensions/extension_downloads_api.h"
39 #include "chrome/browser/extensions/extension_error_reporter.h" 41 #include "chrome/browser/extensions/extension_error_reporter.h"
40 #include "chrome/browser/extensions/extension_global_error.h" 42 #include "chrome/browser/extensions/extension_global_error.h"
41 #include "chrome/browser/extensions/extension_history_api.h" 43 #include "chrome/browser/extensions/extension_history_api.h"
42 #include "chrome/browser/extensions/extension_host.h" 44 #include "chrome/browser/extensions/extension_host.h"
(...skipping 920 matching lines...) Expand 10 before | Expand all | Expand 10 after
963 Source<Profile>(profile_), 965 Source<Profile>(profile_),
964 Details<const std::string>(&extension_id)); 966 Details<const std::string>(&extension_id));
965 967
966 if (sync_bundle && sync_bundle->HasExtensionId(extension_id)) { 968 if (sync_bundle && sync_bundle->HasExtensionId(extension_id)) {
967 sync_bundle->sync_processor->ProcessSyncChanges( 969 sync_bundle->sync_processor->ProcessSyncChanges(
968 FROM_HERE, SyncChangeList(1, sync_change)); 970 FROM_HERE, SyncChangeList(1, sync_change));
969 sync_bundle->synced_extensions.erase(extension_id); 971 sync_bundle->synced_extensions.erase(extension_id);
970 } 972 }
971 973
972 // Track the uninstallation. 974 // Track the uninstallation.
973 UserMetrics::RecordAction( 975 UMA_HISTOGRAM_ENUMERATION("Extensions.ExtensionUninstalled", 1, 2);
974 UserMetricsAction("Extensions.ExtensionUninstalled")); 976
977 static bool default_apps_trial_exists =
978 base::FieldTrialList::TrialExists(kDefaultAppsTrial_Name);
979 if (default_apps_trial_exists) {
980 UMA_HISTOGRAM_ENUMERATION(
981 base::FieldTrial::MakeName("Extensions.ExtensionUninstalled",
982 kDefaultAppsTrial_Name),
983 1, 2);
984 }
975 985
976 // Uninstalling one extension might have solved the problems of others. 986 // Uninstalling one extension might have solved the problems of others.
977 // Therefore, we clear warnings of this type for all extensions. 987 // Therefore, we clear warnings of this type for all extensions.
978 std::set<ExtensionWarningSet::WarningType> warnings; 988 std::set<ExtensionWarningSet::WarningType> warnings;
979 extension_warnings_.GetWarningsAffectingExtension(extension_id, &warnings); 989 extension_warnings_.GetWarningsAffectingExtension(extension_id, &warnings);
980 extension_warnings_.ClearWarnings(warnings); 990 extension_warnings_.ClearWarnings(warnings);
981 991
982 return true; 992 return true;
983 } 993 }
984 994
(...skipping 2021 matching lines...) Expand 10 before | Expand all | Expand 10 after
3006 3016
3007 ExtensionService::NaClModuleInfoList::iterator 3017 ExtensionService::NaClModuleInfoList::iterator
3008 ExtensionService::FindNaClModule(const GURL& url) { 3018 ExtensionService::FindNaClModule(const GURL& url) {
3009 for (NaClModuleInfoList::iterator iter = nacl_module_list_.begin(); 3019 for (NaClModuleInfoList::iterator iter = nacl_module_list_.begin();
3010 iter != nacl_module_list_.end(); ++iter) { 3020 iter != nacl_module_list_.end(); ++iter) {
3011 if (iter->url == url) 3021 if (iter->url == url)
3012 return iter; 3022 return iter;
3013 } 3023 }
3014 return nacl_module_list_.end(); 3024 return nacl_module_list_.end();
3015 } 3025 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698