net: add certificate pins for Twitter.

net: add certificate pins for Twitter.

(Note some lines exceed 80 chars here. Readability suffers by linebreaking so I'm sticking with it.)

BUG=none
TEST=twitter.com still works

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103945

[Chris Palmer, 2011-09-29 21:06:56]

lgtm

http://codereview.chromium.org/8084008/diff/1/net/base/transport_security_sta...
File net/base/transport_security_state.cc (right):

http://codereview.chromium.org/8084008/diff/1/net/base/transport_security_sta...
net/base/transport_security_state.cc:1000: // CDNs, which includes all the keys
from kTwitterAcceptableCerts1.
Nit: Maybe name them kTwitterComAcceptableCerts and kTwitterCDNAcceptableCerts,
so that the names are more immediately meaningful/distinguishable?

http://codereview.chromium.org/8084008/diff/1/net/base/transport_security_sta...
net/base/transport_security_state.cc:1048: #if defined(OS_CHROMEOS)
This is so Twitter can gradually test it with ChromeOS's smaller user base
before going all the way, right? Do we have an ETA on making it standard for all
Chromes?

[agl, 2011-09-29 21:36:40]

http://codereview.chromium.org/8084008/diff/1/net/base/transport_security_sta...
File net/base/transport_security_state.cc (right):

http://codereview.chromium.org/8084008/diff/1/net/base/transport_security_sta...
net/base/transport_security_state.cc:1000: // CDNs, which includes all the keys
from kTwitterAcceptableCerts1.
On 2011/09/29 21:06:56, Chris Palmer wrote:
> Nit: Maybe name them kTwitterComAcceptableCerts and
kTwitterCDNAcceptableCerts,
> so that the names are more immediately meaningful/distinguishable?

Done.

http://codereview.chromium.org/8084008/diff/1/net/base/transport_security_sta...
net/base/transport_security_state.cc:1048: #if defined(OS_CHROMEOS)
On 2011/09/29 21:06:56, Chris Palmer wrote:
> This is so Twitter can gradually test it with ChromeOS's smaller user base
> before going all the way, right?

Right.

> Do we have an ETA on making it standard for all
> Chromes?

Not yet.

[Chris Palmer, 2011-09-29 21:39:53]

lgtm