Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 8083023: Add elfutils to install-build-deps.sh package list (Closed)

Created:
9 years, 2 months ago by Roland McGrath
Modified:
9 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add elfutils to install-build-deps.sh package list The elfutils package is available on every Linux variant, is not very large, and simply adds new utilities called eu-* without affecting anything else. Packaging changes I hope to land later will need to have eu-strip available on the buildbots that do official release builds. BUG= none TEST= none R=bradnelson@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103589

Patch Set 1 #

Total comments: 1

Patch Set 2 : drop a backslash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/install-build-deps.sh View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Roland McGrath
9 years, 2 months ago (2011-09-30 00:08:25 UTC) #1
bradn
http://codereview.chromium.org/8083023/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): http://codereview.chromium.org/8083023/diff/1/build/install-build-deps.sh#newcode105 build/install-build-deps.sh:105: dev_list="apache2.2-bin bison curl elfutils \ Drop the slash.
9 years, 2 months ago (2011-09-30 03:00:34 UTC) #2
Roland McGrath
On 2011/09/30 03:00:34, bradn wrote: > http://codereview.chromium.org/8083023/diff/1/build/install-build-deps.sh > File build/install-build-deps.sh (right): > > http://codereview.chromium.org/8083023/diff/1/build/install-build-deps.sh#newcode105 > ...
9 years, 2 months ago (2011-09-30 16:29:09 UTC) #3
bradn
Lgtm On Sep 30, 2011 9:29 AM, <mcgrathr@chromium.org> wrote: > On 2011/09/30 03:00:34, bradn wrote: ...
9 years, 2 months ago (2011-09-30 17:05:33 UTC) #4
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/mcgrathr@chromium.org/8083023/5001
9 years, 2 months ago (2011-09-30 22:33:20 UTC) #5
commit-bot: I haz the power
9 years, 2 months ago (2011-09-30 23:54:56 UTC) #6
Change committed as 103589

Powered by Google App Engine
This is Rietveld 408576698