Issue 8083003: Convert Windows to POSIX path when calling scm.GIT.CaptureStatus().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8083003: Convert Windows to POSIX path when calling scm.GIT.CaptureStatus(). (Closed)

Created:
9 years, 2 months ago by Alexei Svitkine (slow)

Modified:
9 years, 2 months ago

Reviewers:
commit-bot: I haz the power, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, M-A Ruel, scottmg

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Visibility:
Public.

Description

Convert Windows to POSIX path when calling scm.GIT.CaptureStatus(). Fixes problem in this thread: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/6098b2d0136e650e# This was broken by http://crrev.com/102930, when I made GIT's GenerateDiff() use scm.GIT.CaptureStatus() instead of scm.GIT.GetDifferentFiles(). (Thanks Scott Graham for figuring out the problem!) BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103302

Patch Set 2 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	trychange.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

lgtm with one nit http://codereview.chromium.org/8083003/diff/2001/trychange.py File trychange.py (right): http://codereview.chromium.org/8083003/diff/2001/trychange.py#newcode286 trychange.py:286: return scm.GIT.CaptureStatus(self.checkout_root.replace('\\', '/'), use os.sep ...

9 years, 2 months ago (2011-09-29 17:26:22 UTC) #2

commit-bot: I haz the power

CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8083003/4

9 years, 2 months ago (2011-09-29 17:31:47 UTC) #3

Change committed as 103302

Expand Messages | Collapse Messages

Issue 8083003: Convert Windows to POSIX path when calling scm.GIT.CaptureStatus(). (Closed)

Description

Patch Set 1 : '' #

Patch Set 2 : '' #

Messages