Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8082019: more content exports needed for unit_tests and browser_tests. (Closed)

Created:
9 years, 2 months ago by Dirk Pranke
Modified:
9 years, 2 months ago
Reviewers:
eroman, jam
CC:
chromium-reviews, achuith+watch_chromium.org, dpranke+watch-content_chromium.org, yoshiki+watch_chromium.org, rdsmith+dwatch_chromium.org, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, Ilya Sherman, dhollowa, GeorgeY, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, Avi (use Gerrit), dyu1, yuzo+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, hashimoto+watch_chromium.org, davidbarr+watch_chromium.org, dtseng+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

more content exports needed for unit_tests and browser_tests. R=jam@chromium.org BUG=90442 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103584

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : revert export of browser_accessibility_win for now #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+320 lines, -302 lines) Patch
M chrome/browser/autofill/autofill_download_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/app/content_main.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/browser_main.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/download/download_file_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/download_item.h View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/download/download_types.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/access_token_store.h View 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/dom_storage_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/in_process_webkit/dom_storage_context.h View 1 chunk +3 lines, -4 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_context.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/in_process_webkit/indexed_db_quota_client.h View 2 chunks +3 lines, -2 lines 1 comment Download
M content/browser/in_process_webkit/indexed_db_quota_client_unittest.cc View 1 chunk +230 lines, -230 lines 0 comments Download
M content/browser/intents/intent_injector.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/net/url_request_failed_dns_job.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/net/url_request_slow_download_job.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/plugin_process_host.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/browser_render_process_host.h View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/renderer_host/p2p/socket_host.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_tcp_server.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_host_udp.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/speech/speech_input_dispatcher_host.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/tab_contents/navigation_controller.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/tab_contents/navigation_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/render_view_host_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/content_switches.h View 5 chunks +5 lines, -5 lines 0 comments Download
M content/common/indexed_db_key.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/net/url_fetcher.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/common/serialized_script_value.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/p2p/p2p_transport_impl.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/render_view.h View 3 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/render_widget.h View 2 chunks +7 lines, -4 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Dirk Pranke
9 years, 2 months ago (2011-09-30 22:02:51 UTC) #1
jam
lgtm with nit http://codereview.chromium.org/8082019/diff/4001/content/browser/in_process_webkit/indexed_db_quota_client.h File content/browser/in_process_webkit/indexed_db_quota_client.h (right): http://codereview.chromium.org/8082019/diff/4001/content/browser/in_process_webkit/indexed_db_quota_client.h#newcode13 content/browser/in_process_webkit/indexed_db_quota_client.h:13: #include "content/common/content_client.h" I think you meant ...
9 years, 2 months ago (2011-09-30 22:05:24 UTC) #2
Dirk Pranke
On 2011/09/30 22:05:24, John Abd-El-Malek wrote: > lgtm with nit > > http://codereview.chromium.org/8082019/diff/4001/content/browser/in_process_webkit/indexed_db_quota_client.h > File ...
9 years, 2 months ago (2011-09-30 22:33:37 UTC) #3
Dirk Pranke
Eric, can I get an OWNERS review from you for the stuff in content/common/net?
9 years, 2 months ago (2011-09-30 23:12:33 UTC) #4
jam
it shouldn't be neededed since i've already lgtm'd it, and common/net doesn't have "set noparent" ...
9 years, 2 months ago (2011-09-30 23:15:45 UTC) #5
eroman
LGTM (does need approval for content/browser/net/* files)
9 years, 2 months ago (2011-09-30 23:20:30 UTC) #6
jam
9 years, 2 months ago (2011-09-30 23:21:29 UTC) #7 
oops, I was looking at content/common/net which is what dpranke said :)

On Fri, Sep 30, 2011 at 4:20 PM, <eroman@chromium.org> wrote:

> LGTM
>
> (does need approval for content/browser/net/* files)
>
>
http://codereview.chromium.**org/8082019/<http://codereview.chromium.org/8082...
>

Powered by Google App Engine
This is Rietveld 408576698