Fix bug where --allow-running-insecure-content flag doesn't work against google.com sites in stab...

Fix bug where --allow-running-insecure-content flag doesn't work against google.com sites in stable releases. It is also desirable to fix the need for manual intervention on each promotion to stable, and to beef up the whitelist.

BUG=98611
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104147

[Tom Sepez, 2011-09-29 21:44:43]

This is a better fix for trunk for the mixed content fix I had proposed for M15.


This all arises from wanting different behaviour between dev/beta releases,
where we want to flag all mixed scripting violations by default, and stable
releases, where we only want to flag only a whitelisted set of domains (e.g.
google.com) by default.

Biggest concern is that call to chrome::VersionInfo::GetChannel().  Is this
known to be slow anywhere (seems to do getenv() on unix)?

If this is OK, I'd prefer to merge this to M15 rather than the manual fix I came
up with yesterday.

thanks.

[jam, 2011-09-30 16:22:10]

I defer to Chris on the security. I think you added me only for the content
part. However those switches are only used in chrome, so they belong in
chrome_switches.cc instead.

I'm a bit surprised by the whitelisting of a few domains. It seems unfortunate
to only enable features for a few domains and hardcode them in the code. I
didn't think this is how we rolled out security features, even if they're
experimental.

[Tom Sepez, 2011-09-30 16:26:14]

Yes, unfortunate is the right term for the whitelist.  There's been a lot of
discussion about it, though, with that result.  I'll move the switches as you
suggested after double-checking they don't show under /content.  Thanks.

[Tom Sepez, 2011-09-30 17:14:00]

compile-only try job results after moving the switches:
http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/51963
http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/52199
http://build.chromium.org/p/tryserver.chromium/builders/win/builds/58452

[scarybeasts, 2011-10-04 01:30:29]

LGTM

http://codereview.chromium.org/8080004/diff/11007/chrome/renderer/chrome_rend...
File chrome/renderer/chrome_render_view_observer.cc (right):

http://codereview.chromium.org/8080004/diff/11007/chrome/renderer/chrome_rend...
chrome/renderer/chrome_render_view_observer.cc:149: static const char
kFacebookDotCom[] = "facebook.com";
Nit: recommend alphabetical order.

[Tom Sepez, 2011-10-04 18:56:13]

Adding evan, haraken to take a look at the use of
chrome::VersionInfo::GetChannel().  Tx.