Issue 8079002: Make sure that heap is iterable prior to iterating it in Logger:: methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8079002: Make sure that heap is iterable prior to iterating it in Logger:: methods. (Closed)

Created:
9 years, 2 months ago by mnaganov (inactive)

Modified:
9 years, 2 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Make sure that heap is iterable prior to iterating it in Logger:: methods. R=vegorov@chromium.org BUG=v8:1700 TEST=none Committed: http://code.google.com/p/v8/source/detail?r=9487

Patch Set 1 #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	src/log.cc	View		3 chunks	+3 lines, -0 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM! http://codereview.chromium.org/8079002/diff/1/src/log.cc File src/log.cc (right): http://codereview.chromium.org/8079002/diff/1/src/log.cc#newcode1579 src/log.cc:1579: const int compiled_funcs_count = EnumerateCompiledFunctions(NULL, NULL); add AssertNoAllocation ...

9 years, 2 months ago (2011-09-29 15:01:28 UTC) #2

mnaganov (inactive)

9 years, 2 months ago (2011-09-29 15:06:41 UTC) #3

http://codereview.chromium.org/8079002/diff/1/src/log.cc
File src/log.cc (right):

http://codereview.chromium.org/8079002/diff/1/src/log.cc#newcode1579
src/log.cc:1579: const int compiled_funcs_count =
EnumerateCompiledFunctions(NULL, NULL);
On 2011/09/29 15:01:28, Vyacheslav Egorov wrote:
> add 
> 
> AssertNoAllocation no_alloc;
> 
> for the sake of checking?

It's already stated in EnumerateCompiledFunctions.

Expand Messages | Collapse Messages