chrome/browser/extensions/extension_message_service.cc - Issue 8073023: Merge 101221 - Reland 101111 - Only deliver extension messages to contexts that care.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_message_service.cc

Issue 8073023: Merge 101221 - Reland 101111 - Only deliver extension messages to contexts that care. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/874/src/

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_message_service.h ('k') | chrome/browser/extensions/extension_messages_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_message_service.cc

===================================================================

--- chrome/browser/extensions/extension_message_service.cc (revision 103262)

+++ chrome/browser/extensions/extension_message_service.cc (working copy)

@@ -50,8 +50,6 @@

"Port.dispatchOnConnect";

const char ExtensionMessageService::kDispatchOnDisconnect[] =

"Port.dispatchOnDisconnect";

-const char ExtensionMessageService::kDispatchOnMessage[] =

- "Port.dispatchOnMessage";

namespace {

@@ -88,12 +86,10 @@

}

static void DispatchOnMessage(const ExtensionMessageService::MessagePort& port,

- const std::string& message, int source_port_id) {

- ListValue args;

- args.Set(0, Value::CreateStringValue(message));

- args.Set(1, Value::CreateIntegerValue(source_port_id));

- port.sender->Send(new ExtensionMsg_MessageInvoke(port.routing_id,

- "", ExtensionMessageService::kDispatchOnMessage, args, GURL()));

+ const std::string& message, int target_port_id) {

+ port.sender->Send(

+ new ExtensionMsg_DeliverMessage(

+ port.routing_id, target_port_id, message));

}

} // namespace