Issue 8073020: Fix build with debuggersupport=off.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8073020: Fix build with debuggersupport=off. (Closed)

Created:
9 years, 2 months ago by Yang

Modified:
9 years, 2 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix build with debuggersupport=off. BUG=v8:899 Committed: http://code.google.com/p/v8/source/detail?r=9476

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -9 lines)			Patch
M	src/d8.cc	View	5 chunks	+7 lines, -9 lines	0 comments	Download
M	src/d8-debug.cc	View	2 chunks	+3 lines, -0 lines	1 comment	Download
M	src/flag-definitions.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/full-codegen.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

9 years, 2 months ago (2011-09-29 08:52:04 UTC) #2

LGTM. 

I guess the alternative would be to remove the debuggersupport=off flag
completely, but I'm not sure whether anyone needs it or not.

http://codereview.chromium.org/8073020/diff/1/src/d8-debug.cc
File src/d8-debug.cc (right):

http://codereview.chromium.org/8073020/diff/1/src/d8-debug.cc#newcode1
src/d8-debug.cc:1: // Copyright 2008 the V8 project authors. All rights
reserved.
2011

Expand Messages | Collapse Messages