Finish moving plugin probing out of process.

webkit/plugins/npapi/plugin_lib_mac.mm

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Carbon/Carbon.h>
+#import <CoreFoundation/CoreFoundation.h>
 
 #include "webkit/plugins/npapi/plugin_lib.h"
 
 #include "base/mac/scoped_cftyperef.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/native_library.h"
 #include "base/string_split.h"
 #include "base/string_util.h"
 #include "base/sys_string_conversions.h"
 #include "base/utf_string_conversions.h"
@@ skipping 153 matching lines @@
   // Alternatively (and this is undocumented), rather than a WebPluginMIMETypes
   // key, there may be a WebPluginMIMETypesFilename key. If it is present, then
   // it is the name of a file in the user's preferences folder in which to find
   // the WebPluginMIMETypes key. If the key is present but the file doesn't
   // exist, we must load the plugin and call a specific function to have the
   // plugin create the file.
 
   ScopedCFTypeRef<CFURLRef> bundle_url(CFURLCreateFromFileSystemRepresentation(
       kCFAllocatorDefault, (const UInt8*)filename.value().c_str(),
       filename.value().length(), true));
-  if (!bundle_url)
+  if (!bundle_url) {
+    LOG_IF(ERROR, PluginList::DebugPluginLoading())
+        << "PluginLib::ReadWebPluginInfo could not create bundle URL";
     return false;
+  }
   ScopedCFTypeRef<CFBundleRef> bundle(CFBundleCreate(kCFAllocatorDefault,
                                                      bundle_url.get()));
-  if (!bundle)
+  if (!bundle) {
+    LOG_IF(ERROR, PluginList::DebugPluginLoading())
+        << "PluginLib::ReadWebPluginInfo could not create CFBundleRef";
     return false;
+  }
 
   // preflight
 
   OSType type = 0;
   CFBundleGetPackageInfo(bundle.get(), &type, NULL);
-  if (type != FOUR_CHAR_CODE('BRPL'))
+  if (type != FOUR_CHAR_CODE('BRPL')) {
+    LOG_IF(ERROR, PluginList::DebugPluginLoading())
+        << "PluginLib::ReadWebPluginInfo bundle is not BRPL, is " << type;
     return false;
+  }
 
   CFErrorRef error;
   Boolean would_load = CFBundlePreflightExecutable(bundle.get(), &error);
-  if (!would_load)
+  if (!would_load) {
+    ScopedCFTypeRef<CFStringRef> error_string(CFErrorCopyDescription(error));
+    LOG_IF(ERROR, PluginList::DebugPluginLoading())
+        << "PluginLib::ReadWebPluginInfo bundle failed preflight: "
+        << base::SysCFStringRefToUTF8(error_string);
     return false;
+  }
 
   // get the info
 
   if (ReadPlistPluginInfo(filename, bundle.get(), info))
     return true;
 
   // ... or not
 
   return false;
 }
 
 }  // namespace npapi
 }  // namespace webkit