Issue 8070003: touchui: Convert XI2 MT tracking id to slot id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8070003: touchui: Convert XI2 MT tracking id to slot id. (Closed)

Created:
9 years, 2 months ago by sadrul

Modified:
9 years, 2 months ago

Reviewers:
sky, Daniel Kurtz

CC:
chromium-reviews, dhollowa, ningxin.hu

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

touchui: Convert XI2 MT tracking id to slot id. The slot id mapped from tracking id is used as the touch id, and the gesture recognizer expects touch points to always start from 0. Patch from: Ningxin Hu <ningxin.hu@intel.com>; (http://codereview.chromium.org/7927001/) BUG=95150 TEST=manually (touch-drag to scroll webpage, tap to click link) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103122

Patch Set 1 #

Patch Set 2 : small nits #

Total comments: 2

Patch Set 3 : . #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -22 lines)			Patch
M	ui/base/touch/touch_factory.h	View	1	3 chunks	+21 lines, -4 lines	0 comments	Download
M	ui/base/touch/touch_factory.cc	View	1 2	3 chunks	+39 lines, -6 lines	0 comments	Download
M	views/events/event_x.cc	View		2 chunks	+33 lines, -12 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sadrul

The patch is from ningxin.hu (http://codereview.chromium.org/7927001/), with small additional style changes. PTAL.

9 years, 2 months ago (2011-09-28 15:11:39 UTC) #1

sky

LGTM http://codereview.chromium.org/8070003/diff/2001/ui/base/touch/touch_factory.cc File ui/base/touch/touch_factory.cc (right): http://codereview.chromium.org/8070003/diff/2001/ui/base/touch/touch_factory.cc#newcode141 ui/base/touch/touch_factory.cc:141: tracking_id_map_(), nit: remove this from initializer list.

9 years, 2 months ago (2011-09-28 16:09:47 UTC) #4

sadrul

9 years, 2 months ago (2011-09-28 16:16:54 UTC) #5

Thanks!

http://codereview.chromium.org/8070003/diff/2001/ui/base/touch/touch_factory.cc
File ui/base/touch/touch_factory.cc (right):

http://codereview.chromium.org/8070003/diff/2001/ui/base/touch/touch_factory....
ui/base/touch/touch_factory.cc:141: tracking_id_map_(),
On 2011/09/28 16:09:48, sky wrote:
> nit: remove this from initializer list.

Done.

Expand Messages | Collapse Messages