Issue 8070002: Pass correct anchor_slot for EMBEDDED_OBJECT pointers from code objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8070002: Pass correct anchor_slot for EMBEDDED_OBJECT pointers from code objects. (Closed)

Created:
9 years, 2 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 2 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Pass correct anchor_slot for EMBEDDED_OBJECT pointers from code objects. Correctly initialize newly created large-object pages when incremental marking with compaction is in progress. R=erik.corry@gmail.com BUG=v8:1737 Committed: http://code.google.com/p/v8/source/detail?r=9475

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -29 lines)			Patch
M	src/arm/assembler-arm-inl.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/assembler-ia32-inl.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/incremental-marking.h	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	src/incremental-marking.cc	View	7 chunks	+24 lines, -18 lines	0 comments	Download
M	src/mark-compact.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	src/mips/assembler-mips-inl.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+4 lines, -0 lines	1 comment	Download
M	src/x64/assembler-x64-inl.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

9 years, 2 months ago (2011-09-28 14:57:12 UTC) #2

LGTM

http://codereview.chromium.org/8070002/diff/1/src/objects.h
File src/objects.h (right):

http://codereview.chromium.org/8070002/diff/1/src/objects.h#newcode7506
src/objects.h:7506: VisitPointer(p);
Comment?

Expand Messages | Collapse Messages