Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1415)

Unified Diff: content/browser/in_process_webkit/indexed_db_quota_client.h

Issue 8070001: Use base::Callback in Quota related code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: choke lint Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/in_process_webkit/indexed_db_quota_client.h
diff --git a/content/browser/in_process_webkit/indexed_db_quota_client.h b/content/browser/in_process_webkit/indexed_db_quota_client.h
index 29ded7b120aaa8fce9b92dc40a02a85ffc4a04cc..3261cad1e6e59eddf616968ca2160ddfaadc12fc 100644
--- a/content/browser/in_process_webkit/indexed_db_quota_client.h
+++ b/content/browser/in_process_webkit/indexed_db_quota_client.h
@@ -32,15 +32,15 @@ class IndexedDBQuotaClient : public quota::QuotaClient,
virtual void OnQuotaManagerDestroyed() OVERRIDE;
virtual void GetOriginUsage(const GURL& origin_url,
quota::StorageType type,
- GetUsageCallback* callback) OVERRIDE;
+ GetUsageCallback callback) OVERRIDE;
awong 2011/09/29 18:05:15 It's better to pass the Callback by const &.
tzik 2011/10/11 04:53:57 Done.
virtual void GetOriginsForType(quota::StorageType type,
- GetOriginsCallback* callback) OVERRIDE;
+ GetOriginsCallback callback) OVERRIDE;
awong 2011/09/29 18:05:15 pass by const &
tzik 2011/10/11 04:53:57 Done.
virtual void GetOriginsForHost(quota::StorageType type,
const std::string& host,
- GetOriginsCallback* callback) OVERRIDE;
+ GetOriginsCallback callback) OVERRIDE;
awong 2011/09/29 18:05:15 pass by const &
tzik 2011/10/11 04:53:57 Done.
virtual void DeleteOriginData(const GURL& origin,
quota::StorageType type,
- DeletionCallback* callback) OVERRIDE;
+ DeletionCallback callback) OVERRIDE;
awong 2011/09/29 18:05:15 pass by const &
tzik 2011/10/11 04:53:57 Done.
private:
class HelperTask;
class GetOriginUsageTask;
@@ -50,17 +50,17 @@ class IndexedDBQuotaClient : public quota::QuotaClient,
class DeleteOriginTask;
typedef quota::CallbackQueueMap1
- <GetUsageCallback*,
+ <GetUsageCallback,
GURL, // origin
int64
> UsageForOriginCallbackMap;
typedef quota::CallbackQueue2
- <GetOriginsCallback*,
+ <GetOriginsCallback,
const std::set<GURL>&,
quota::StorageType
> OriginsForTypeCallbackQueue;
typedef quota::CallbackQueueMap2
- <GetOriginsCallback*,
+ <GetOriginsCallback,
std::string, // host
const std::set<GURL>&,
quota::StorageType

Powered by Google App Engine
This is Rietveld 408576698