Issue 8068028: Remove version hacks for platform version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8068028: Remove version hacks for platform version. (Closed)

Created:
9 years, 2 months ago by rkc

Modified:
9 years, 2 months ago

Reviewers:
DaveMoore, Evan Martin, zel

CC:
chromium-reviews, stevenjb, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove version hacks for platform version. ChromeOS is now using platform numbers as intended, hence the hacks put in place to extract the platform numbers from the old ChromeOS version numbers are no longer needed. Removed them. R=davemoore@chromium.org,evan@chromium.org,zelidrag@chromium.org BUG=chromium-os:20934 TEST=Checked all places where the version shows up. On the latest build it was breaking, it shows correctly again after this fix. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103687

Patch Set 1 #

Total comments: 1

Patch Set 2 : Test fix + Nit fix. #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -44 lines)			Patch
M	base/sys_info_chromeos.cc	View	1	1 chunk	+4 lines, -7 lines	0 comments	Download
M	base/sys_info_unittest.cc	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/browser_about_handler.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/version_info_updater.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/version_loader.h	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/chromeos/version_loader.cc	View		3 chunks	+0 lines, -22 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/about_page_handler.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

DaveMoore

9 years, 2 months ago (2011-09-30 21:07:16 UTC) #3

lgtm

http://codereview.chromium.org/8068028/diff/1/base/sys_info_chromeos.cc
File base/sys_info_chromeos.cc (right):

http://codereview.chromium.org/8068028/diff/1/base/sys_info_chromeos.cc#newco...
base/sys_info_chromeos.cc:97: for (int i = 0; i < 3 && tokenizer.GetNext(); i++)
{
Nit: ++i

Expand Messages | Collapse Messages