Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 8068008: Add post_processors override to apply_patch() and add more testing. (Closed)

Created:
9 years, 2 months ago by M-A Ruel
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Add post_processors override to apply_patch() and add more testing. Move ReadOnlyCheckout tests into its own fixture. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103272

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -106 lines) Patch
M checkout.py View 9 chunks +16 lines, -10 lines 1 comment Download
M tests/checkout_test.py View 13 chunks +94 lines, -96 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
http://codereview.chromium.org/8068008/diff/1/checkout.py File checkout.py (right): http://codereview.chromium.org/8068008/diff/1/checkout.py#newcode711 checkout.py:711: def apply_patch(self, patches, post_processors=None): It's mainly for this edge ...
9 years, 2 months ago (2011-09-28 19:28:07 UTC) #1
Dirk Pranke
lgtm
9 years, 2 months ago (2011-09-28 23:29:50 UTC) #2
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8068008/1
9 years, 2 months ago (2011-09-29 14:08:05 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-09-29 14:13:57 UTC) #4
Change committed as 103272

Powered by Google App Engine
This is Rietveld 408576698