Issue 8066008: Fix the no-VFP3 build on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8066008: Fix the no-VFP3 build on ARM. (Closed)

Created:
9 years, 2 months ago by Erik Corry

Modified:
9 years, 2 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix the no-VFP3 build on ARM. Committed: http://code.google.com/p/v8/source/detail?r=9468

Patch Set 3 : '' #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	src/arm/code-stubs-arm.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	src/arm/code-stubs-arm.cc	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. http://codereview.chromium.org/8066008/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/8066008/diff/1/src/arm/code-stubs-arm.cc#newcode3419 src/arm/code-stubs-arm.cc:3419: StoreBufferOverflowStub stub2(kSaveFPRegs); Nit of the day: Since there ...

9 years, 2 months ago (2011-09-28 13:05:45 UTC) #2

Expand Messages | Collapse Messages

Issue 8066008: Fix the no-VFP3 build on ARM. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages