Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 8066007: Small simplification of HChange instruction. (Closed)

Created:
9 years, 2 months ago by fschneider
Modified:
9 years, 2 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Small simplification of HChange instruction. Use existing flag to mark HChange instructions that deoptimize on undefined. Also there is no need to store the source representation explicitly. Committed: http://code.google.com/p/v8/source/detail?r=9472

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -135 lines) Patch
M src/hydrogen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 114 chunks +124 lines, -133 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
fschneider
The cl looks larger than it is. It is really just a small refactoring of ...
9 years, 2 months ago (2011-09-28 13:42:55 UTC) #1
Jakob Kummerow
9 years, 2 months ago (2011-09-28 13:55:50 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698