Fast allocation of block contexts.

Fast allocation of block contexts.

[Steven, 2011-09-28 09:48:20]

PTAL.

This CL depends on
http://codereview.chromium.org/8065002/ .

[danno, 2011-10-05 12:30:09]

lgtm with nits.

http://codereview.chromium.org/8066002/diff/1/src/code-stubs.h
File src/code-stubs.h (right):

http://codereview.chromium.org/8066002/diff/1/src/code-stubs.h#newcode358
src/code-stubs.h:358: ASSERT(slots_ > 0 && slots <= kMaximumSlots);
nit: use either both slots_ or slots

http://codereview.chromium.org/8066002/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/8066002/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:202: for (int i = Context::MIN_CONTEXT_SLOTS; i <
length; i++) {
Maybe it's clearer to iterate from 0 to slots_ and store at i +
Context::MIN_CONTEXT_SLOTS?

http://codereview.chromium.org/8066002/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:208: __ mov(esi, Operand(eax));
just use eax, not Operand(eax)

[Steven, 2011-10-05 15:40:03]

RFAL.

http://codereview.chromium.org/8066002/diff/1/src/code-stubs.h
File src/code-stubs.h (right):

http://codereview.chromium.org/8066002/diff/1/src/code-stubs.h#newcode358
src/code-stubs.h:358: ASSERT(slots_ > 0 && slots <= kMaximumSlots);
On 2011/10/05 12:30:09, danno wrote:
> nit: use either both slots_ or slots

Done.

http://codereview.chromium.org/8066002/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/8066002/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:202: for (int i = Context::MIN_CONTEXT_SLOTS; i <
length; i++) {
On 2011/10/05 12:30:09, danno wrote:
> Maybe it's clearer to iterate from 0 to slots_ and store at i +
> Context::MIN_CONTEXT_SLOTS?

Done.

http://codereview.chromium.org/8066002/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:208: __ mov(esi, Operand(eax));
On 2011/10/05 12:30:09, danno wrote:
> just use eax, not Operand(eax)

Done.

[danno, 2011-10-06 14:44:08]

lgtm

http://codereview.chromium.org/8066002/diff/8001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/8066002/diff/8001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:221: __ JumpIfNotSmi(r3, &after_sentinel);
Make a debug check for zero?

[Steven, 2011-10-06 16:02:40]

http://codereview.chromium.org/8066002/diff/8001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/8066002/diff/8001/src/arm/code-stubs-arm.cc#ne...
src/arm/code-stubs-arm.cc:221: __ JumpIfNotSmi(r3, &after_sentinel);
On 2011/10/06 14:44:08, danno wrote:
> Make a debug check for zero? 

Done.