[Sync] Refactor non-frontend DTC to handle new API properly.

chrome/browser/extensions/extension_service.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 57 matching lines @@
 class Profile;
 class SyncData;
 class Version;
 
 namespace chromeos {
 class ExtensionInputMethodEventRouter;
 }  // namespace chromeos
 
 // This is an interface class to encapsulate the dependencies that
 // various classes have on ExtensionService. This allows easy mocking.
-class ExtensionServiceInterface : public SyncableService {
+class ExtensionServiceInterface
+    : public SyncableService,
+      public base::SupportsWeakPtr<ExtensionServiceInterface> {

[akalin, 2011/10/12 19:54:21]

can you stick this onto the actual ExtensionService class?  Actually, it may
already support weak pointers; I'm pretty sure it at least has a WeakPtrFactory.

You may want to do the "make every syncableservice inherit from SupportsWeakPtr"
thing as a separate CL, as it may involve other OWNERS, and this CL is pretty
big already.

[Nicolas Zea, 2011/10/12 23:47:43]

Discussed offline. Sticking with SyncableService implementing the weakptr for
now, with a TODO to transition to the services themselves implementing it.

  public:
   // A function that returns true if the given extension should be
   // included and false if it should be filtered out.  Identical to
   // PendingExtensionInfo::ShouldAllowInstallPredicate.
   typedef bool (*ExtensionFilter)(const Extension&);
 
   virtual ~ExtensionServiceInterface() {}
   virtual const ExtensionList* extensions() const = 0;
   virtual PendingExtensionManager* pending_extension_manager() = 0;
 
@@ skipping 737 matching lines @@
   ExtensionWarningSet extension_warnings_;
 
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            InstallAppsWithUnlimtedStorage);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            InstallAppsAndCheckStorageProtection);
   DISALLOW_COPY_AND_ASSIGN(ExtensionService);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_