Issue 8065006: Move the is_pregenerated flag so it does not overlap other flags.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8065006: Move the is_pregenerated flag so it does not overlap other flags. (Closed)

Created:
9 years, 2 months ago by Erik Corry

Modified:
9 years, 2 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Move the is_pregenerated flag so it does not overlap other flags. Remove the before-or-after InstanceOf stub rule, which was too subtle and lacked checking ssertions. Unify the way the CEntry stub is pregenerated so that it is done in the same way. Committed: http://code.google.com/p/v8/source/detail?r=9466

Patch Set 1 #

Total comments: 1

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -16 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	2 chunks	+8 lines, -0 lines	1 comment	Download
M	src/code-stubs.h	View	3 chunks	+2 lines, -10 lines	0 comments	Download
M	src/code-stubs.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/heap.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	2 chunks	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

9 years, 2 months ago (2011-09-28 12:11:27 UTC) #2

LGMT

http://codereview.chromium.org/8065006/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/8065006/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:3423: void
CEntryStub::GenerateFixedRegStubsAheadOfTime() {
method name is missleading. there is nothing about fixed regs here.

Expand Messages | Collapse Messages