Issue 8065004: Porting r9456 to arm (Optimize KeyedStoreGeneric for Smi arrays).

Issue 8065004: Porting r9456 to arm (Optimize KeyedStoreGeneric for Smi arrays). (Closed)

Created:
9 years, 2 months ago by Yang

Modified:
9 years, 2 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Porting r9456 to arm (Optimize KeyedStoreGeneric for Smi arrays). Committed: http://code.google.com/p/v8/source/detail?r=9531

Patch Set 1 #

Patch Set 2 : Changed according to Florian's suggestions in the CL for the x64 port. #

Patch Set 3 : small change. #

Total comments: 4

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -101 lines)			Patch
M	src/arm/ic-arm.cc	View	1 2	7 chunks	+43 lines, -19 lines	2 comments	Download
M	src/arm/macro-assembler-arm.h	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View		1 chunk	+90 lines, -0 lines	1 comment	Download
M	src/arm/stub-cache-arm.cc	View		2 chunks	+11 lines, -82 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Yang

Please take a look. This is a port of http://codereview.chromium.org/8022002/

9 years, 2 months ago (2011-09-28 10:48:59 UTC) #1

Yang

On 2011/09/28 10:48:59, Yang wrote: > Please take a look. This is a port of ...

9 years, 2 months ago (2011-09-29 12:23:11 UTC) #2

Yang

*gentle nudge* On 2011/09/29 12:23:11, Yang wrote: > On 2011/09/28 10:48:59, Yang wrote: > > ...

9 years, 2 months ago (2011-10-04 14:41:12 UTC) #3

Rico

9 years, 2 months ago (2011-10-05 08:39:19 UTC) #4

LGTM

http://codereview.chromium.org/8065004/diff/3002/src/arm/ic-arm.cc
File src/arm/ic-arm.cc (right):

http://codereview.chromium.org/8065004/diff/3002/src/arm/ic-arm.cc#newcode1323
src/arm/ic-arm.cc:1323: // r2: receiver.
r5: receiver map

http://codereview.chromium.org/8065004/diff/3002/src/arm/ic-arm.cc#newcode1413
src/arm/ic-arm.cc:1413: __ StoreNumberToDoubleElements(value, key, receiver,
elements,
all arguments on one line or each on seperate line (on one line will not work
here I guess :-) )

http://codereview.chromium.org/8065004/diff/3002/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):

http://codereview.chromium.org/8065004/diff/3002/src/arm/macro-assembler-arm....
src/arm/macro-assembler-arm.cc:1953: // scratch is now effective address of the
double element
scratch1

http://codereview.chromium.org/8065004/diff/3002/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/8065004/diff/3002/src/arm/stub-cache-arm.cc#ne...
src/arm/stub-cache-arm.cc:4433: __ StoreNumberToDoubleElements(value_reg,
key_reg, receiver_reg, elements_reg,
all arguments on one line or each on separate lines

Expand Messages | Collapse Messages