Issue 8065003: Shrink the new space and uncommit marking deque on low memory notification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8065003: Shrink the new space and uncommit marking deque on low memory notification. (Closed)

Created:
9 years, 2 months ago by ulan

Modified:
9 years, 1 month ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Shrink the new space and uncommit marking deque on low memory notification. BUG=v8:1669 TEST=cctest/test-heap/CollectingAllAvailableGarbageShrinksNewSpace Committed: http://code.google.com/p/v8/source/detail?r=9912

Patch Set 1 #

Total comments: 2

Patch Set 2 : Clear compilation cache #

Patch Set 3 : Rebased #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -12 lines)			Patch
M	src/heap.cc	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/incremental-marking.h	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/incremental-marking.cc	View	1 2	2 chunks	+17 lines, -1 line	0 comments	Download
M	test/cctest/test-heap.cc	View	1 2	3 chunks	+30 lines, -11 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

Please take a look when you have time. I will commit it once NewGC is ...

9 years, 2 months ago (2011-09-28 10:08:47 UTC) #1

ulan

I noticed that IdleNotification clears compilation cache sometimes. Would it be useful to do the ...

9 years, 2 months ago (2011-09-29 08:36:48 UTC) #3

Vyacheslav Egorov (Chromium)

9 years, 2 months ago (2011-09-29 14:06:11 UTC) #4

http://codereview.chromium.org/8065003/diff/1/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/8065003/diff/1/src/heap.cc#newcode451
src/heap.cc:451: const int kMaxNumberOfAttempts = 7;
On 2011/09/29 08:36:58, ulan wrote:
> Add isolate_->compilation_cache()->Clear() ?

Yep, lets do that. Good catch.

Expand Messages | Collapse Messages