Issue 8060052: Fix leakage of virtual address space on Linux platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8060052: Fix leakage of virtual address space on Linux platform. (Closed)

Created:
9 years, 2 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 2 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix leakage of virtual address space on Linux platform. Ensure that unmap return values are checked in debug mode. R=erik.corry@gmail.com BUG=v8:1701 Committed: http://code.google.com/p/v8/source/detail?r=9480

Patch Set 1 #

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -25 lines)			Patch
M	src/platform.h	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/platform-linux.cc	View	3 chunks	+19 lines, -9 lines	0 comments	Download
M	src/platform-macos.cc	View	2 chunks	+18 lines, -8 lines	0 comments	Download
M	src/platform-openbsd.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/platform-win32.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/spaces.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

9 years, 2 months ago (2011-09-29 12:12:07 UTC) #2

LGTM

Is it possible to put helper functions in platform-posix.cc and and then call
them from the others?  It seems likely that the new GC doesn't work on OpenBSD,
FreeBSD and Solaris/Illumos at the moment.

Expand Messages | Collapse Messages