Add downloads.onCreated apitest and fix a few bugs

content/browser/download/download_request_handle.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/download_request_handle.h"
 
 #include "base/stringprintf.h"
 #include "content/browser/browser_context.h"
 #include "content/browser/browser_thread.h"
 #include "content/browser/renderer_host/render_view_host.h"
@@ skipping 43 matching lines @@
 TabContents* DownloadRequestHandle::GetTabContents() const {
   RenderViewHost* render_view_host =
       RenderViewHost::FromID(child_id_, render_view_id_);
   if (!render_view_host)
     return NULL;
 
   return render_view_host->delegate()->GetAsTabContents();
 }
 
 DownloadManager* DownloadRequestHandle::GetDownloadManager() const {
-  TabContents* contents = GetTabContents();
-  if (!contents)
-    return NULL;
-
-  content::BrowserContext* browser_context = contents->browser_context();
-  if (!browser_context)
-    return NULL;
-
-  return browser_context->GetDownloadManager();
+  return RenderViewHost::FromID(child_id_, render_view_id_)->process()
+    ->browser_context()->GetDownloadManager();

[Randy Smith (Not in Mondays), 2011/10/17 17:39:56]

Random thought that you're welcome to bounce as not being appropriate for this
CL: Now that we have global ids that include the DownloadManager, could we nuke
this method on DownloadRequestHandle and just get the DM from there?  I *think*
we have access to a global_id everywhere we have a DownloadRequestHandle.  

[benjhayden, 2011/10/17 17:54:29]

I thought that we decided that that would be breaking the DownloadId
abstraction? Meh, we can do it in DownloadId part 2 if that SGTY. I'd like to
try to keep this cl small.

 }
 
 void DownloadRequestHandle::PauseRequest() const {
   // The post is safe because ResourceDispatcherHost is guaranteed
   // to outlive the IO thread.
   if (rdh_) {
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         NewRunnableFunction(&ResourceDispatcherHostPauseRequest,
                             rdh_, child_id_, request_id_, true));
@@ skipping 25 matching lines @@
 std::string DownloadRequestHandle::DebugString() const {
   return base::StringPrintf("{"
                             " child_id = %d"
                             " render_view_id = %d"
                             " request_id = %d"
                             "}",
                             child_id_,
                             render_view_id_,
                             request_id_);
 }