Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 8060038: Upstream: The change of common.gypi (Closed)

Created:
9 years, 2 months ago by michaelbai
Modified:
9 years, 2 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, jrg, Peter Beverloo, Jing Zhao
Visibility:
Public.

Description

Upstream: The change of common.gypi - Exclude android specific files when building with 'host' toolset. - Not using system icu by default. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103286

Patch Set 1 : Added the missing toolset change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/common.gypi View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
michaelbai
Hi Mark, Please help to review this.
9 years, 2 months ago (2011-09-28 19:19:12 UTC) #1
Mark Mentovai
9 years, 2 months ago (2011-09-28 19:30:39 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698