Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 8060026: Enable PYTHONDONTWRITEBYTECODE=1 as much as possible. (Closed)

Created:
9 years, 2 months ago by M-A Ruel
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke
Visibility:
Public.

Description

Enable PYTHONDONTWRITEBYTECODE=1 as much as possible. Since we clobber the .pyc, it's not useful to generate them in the first place. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103066

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M drover View 1 chunk +1 line, -2 lines 0 comments Download
M drover.bat View 1 chunk +1 line, -1 line 0 comments Download
M gcl View 1 chunk +1 line, -1 line 0 comments Download
M gcl.bat View 1 chunk +1 line, -0 lines 0 comments Download
M gclient View 1 chunk +1 line, -1 line 0 comments Download
M git-cl View 1 chunk +2 lines, -2 lines 0 comments Download
M git-try View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
9 years, 2 months ago (2011-09-28 00:02:53 UTC) #1
Dirk Pranke
lgtm. do we have a way of measuring if there is any perf impact from ...
9 years, 2 months ago (2011-09-28 00:07:02 UTC) #2
M-A Ruel
On 2011/09/28 00:07:02, Dirk Pranke wrote: > lgtm. > > do we have a way ...
9 years, 2 months ago (2011-09-28 00:11:15 UTC) #3
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8060026/1
9 years, 2 months ago (2011-09-28 00:11:41 UTC) #4
commit-bot: I haz the power
9 years, 2 months ago (2011-09-28 00:11:46 UTC) #5
Can't apply patch for file depot_tools/gcl.bat.
While running patch -p1 --forward --force;
patching file depot_tools/gcl.bat
Hunk #1 FAILED at 2.
1 out of 1 hunk FAILED -- saving rejects to file depot_tools/gcl.bat.rej

Powered by Google App Engine
This is Rietveld 408576698