Issue 8060022: Move Leopard compatible block code to content/.

Issue 8060022: Move Leopard compatible block code to content/. (Closed)

Created:
9 years, 2 months ago by Avi (use Gerrit)

Modified:
9 years, 2 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, dpranke+watch-content_chromium.org, jam, joi+watch-content_chromium.org, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move Leopard compatible block code to content/. BUG=95573 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103017

Patch Set 2 : clean #

Total comments: 2

Created: 9 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -412 lines)			Patch
D	chrome/browser/mac/closure_blocks_leopard_compat.h	View		1 chunk	+0 lines, -104 lines	0 comments	Download
D	chrome/browser/mac/closure_blocks_leopard_compat.S	View		1 chunk	+0 lines, -139 lines	0 comments	Download
D	chrome/browser/mac/closure_blocks_leopard_compat_unittest.cc	View		1 chunk	+0 lines, -98 lines	0 comments	Download
M	chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm	View		2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View		2 chunks	+1 line, -62 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		3 chunks	+2 lines, -3 lines	0 comments	Download
A +	content/browser/mac/closure_blocks_leopard_compat.h	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
A +	content/browser/mac/closure_blocks_leopard_compat.S	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	content/browser/mac/closure_blocks_leopard_compat_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/content.gyp	View		1 chunk	+62 lines, -0 lines	0 comments	Download
M	content/content_browser.gypi	View		1 chunk	+3 lines, -0 lines	2 comments	Download
M	content/content_tests.gypi	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM http://codereview.chromium.org/8060022/diff/1001/content/content_browser.gypi File content/content_browser.gypi (right): http://codereview.chromium.org/8060022/diff/1001/content/content_browser.gypi#newcode608 content/content_browser.gypi:608: 'dependencies': [ You’re not using this in here ...

9 years, 2 months ago (2011-09-27 21:45:50 UTC) #2

Avi (use Gerrit)

9 years, 2 months ago (2011-09-27 21:50:08 UTC) #3

http://codereview.chromium.org/8060022/diff/1001/content/content_browser.gypi
File content/content_browser.gypi (right):

http://codereview.chromium.org/8060022/diff/1001/content/content_browser.gypi...
content/content_browser.gypi:608: 'dependencies': [
On 2011/09/27 21:45:50, Mark Mentovai wrote:
> You’re not using this in here yet, right? Could you hold off on adding this
> until the change that first uses blocks in this library? content_browser, I
> guess.

OK.

Expand Messages | Collapse Messages