base/threading/thread_unittest.cc - Issue 8060011: Suppress benign race in ThreadTest.SleepInsideInit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/threading/thread_unittest.cc

Issue 8060011: Suppress benign race in ThreadTest.SleepInsideInit (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/threading/thread_unittest.cc

diff --git a/base/threading/thread_unittest.cc b/base/threading/thread_unittest.cc

index c7cb76abec6eb8e9af6e47888f93794edf10eb49..0499e073bf310b22d990426178c5eb1c06d0b63a 100644

--- a/base/threading/thread_unittest.cc

+++ b/base/threading/thread_unittest.cc

@@ -43,7 +43,10 @@ class SleepSome : public Task {

class SleepInsideInitThread : public Thread {

public:

- SleepInsideInitThread() : Thread("none") { init_called_ = false; }

+ SleepInsideInitThread() : Thread("none") {

+ init_called_ = false;

+ ANNOTATE_BENIGN_RACE(this, "http://crbug.com/98219");

+ }

virtual ~SleepInsideInitThread() { }

virtual void Init() {

« no previous file with comments | « no previous file | no next file » | no next file with comments »