Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 8059011: Dependency.url is also immutable. Convert more member as properties (Closed)

Created:
9 years, 2 months ago by M-A Ruel
Modified:
9 years, 2 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Dependency.url is also immutable. Convert more member as properties. Merge _FindDependencies() back into __init__() now that __init__() is somewhat smaller. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=103053

Patch Set 1 #

Patch Set 2 : merge _FindDependencies into __init__ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -41 lines) Patch
M gclient.py View 1 12 chunks +60 lines, -41 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
9 years, 2 months ago (2011-09-27 16:08:09 UTC) #1
Dirk Pranke
lgtm
9 years, 2 months ago (2011-09-27 22:21:30 UTC) #2
commit-bot: I haz the power
CQ is trying tha patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8059011/1002
9 years, 2 months ago (2011-09-27 23:47:50 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-09-27 23:53:34 UTC) #4
Change committed as 103053

Powered by Google App Engine
This is Rietveld 408576698